Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: chrome/browser/ui/webui/downloads_dom_handler.cc

Issue 442133002: Typecheck chrome://downloads using CompilerPass.java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master
Patch Set: fixes after comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/downloads/downloads.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/downloads_dom_handler.cc
diff --git a/chrome/browser/ui/webui/downloads_dom_handler.cc b/chrome/browser/ui/webui/downloads_dom_handler.cc
index 84ec86f96d6877e8b02fa0357c91f7822b14a9b2..e917015ce9adb26da7d1764f1bb186186ed9e627 100644
--- a/chrome/browser/ui/webui/downloads_dom_handler.cc
+++ b/chrome/browser/ui/webui/downloads_dom_handler.cc
@@ -118,6 +118,11 @@ base::DictionaryValue* CreateDownloadItemValue(
// progress. The difference currently only matters to Drive downloads and
// those don't show up on the downloads page, but should.
DownloadItemModel download_model(download_item);
+
+ // The items which are to be written into file_value are also described in
+ // chrome/browser/resources/downloads/downloads.js in @typedef for
+ // BackendDownloadObject. Please update it whenever you add or remove
+ // any keys in file_value.
base::DictionaryValue* file_value = new base::DictionaryValue();
file_value->SetInteger(
« no previous file with comments | « chrome/browser/resources/downloads/downloads.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698