chrome/browser/services/gcm/push_messaging_service_impl.cc - Issue 442123003: [GCM] Adding the OnSendAcknowledgement event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/push_messaging_service_impl.cc

Issue 442123003: [GCM] Adding the OnSendAcknowledgement event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing code review comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/services/gcm/push_messaging_service_impl.cc

diff --git a/chrome/browser/services/gcm/push_messaging_service_impl.cc b/chrome/browser/services/gcm/push_messaging_service_impl.cc

index 351ca81d3dc05d2d2b77c178bf269d7bf6fcbb31..e607b68146996728dc696b8397900a3645ab8e9b 100644

--- a/chrome/browser/services/gcm/push_messaging_service_impl.cc

+++ b/chrome/browser/services/gcm/push_messaging_service_impl.cc

@@ -132,6 +132,12 @@ void PushMessagingServiceImpl::OnSendError(

NOTREACHED() << "The Push API shouldn't have sent messages upstream";

}

+void PushMessagingServiceImpl::OnSendAcknowledged(

+ const std::string& app_id,

+ const std::string& message_id) {

+ NOTREACHED() << "The Push API shouldn't have sent messages upstream";

void PushMessagingServiceImpl::Register(

const GURL& origin,

int64 service_worker_registration_id,