Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: chrome/browser/services/gcm/push_messaging_service_impl.cc

Issue 442123003: [GCM] Adding the OnSendAcknowledgement event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing code review comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/services/gcm/push_messaging_service_impl.h" 5 #include "chrome/browser/services/gcm/push_messaging_service_impl.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 // TODO(mvanouwerkerk): Fire push error event on the Service Worker 125 // TODO(mvanouwerkerk): Fire push error event on the Service Worker
126 // corresponding to app_id. 126 // corresponding to app_id.
127 } 127 }
128 128
129 void PushMessagingServiceImpl::OnSendError( 129 void PushMessagingServiceImpl::OnSendError(
130 const std::string& app_id, 130 const std::string& app_id,
131 const GCMClient::SendErrorDetails& send_error_details) { 131 const GCMClient::SendErrorDetails& send_error_details) {
132 NOTREACHED() << "The Push API shouldn't have sent messages upstream"; 132 NOTREACHED() << "The Push API shouldn't have sent messages upstream";
133 } 133 }
134 134
135 void PushMessagingServiceImpl::OnSendAcknowledged(
136 const std::string& app_id,
137 const std::string& message_id) {
138 NOTREACHED() << "The Push API shouldn't have sent messages upstream";
139 }
140
135 void PushMessagingServiceImpl::Register( 141 void PushMessagingServiceImpl::Register(
136 const GURL& origin, 142 const GURL& origin,
137 int64 service_worker_registration_id, 143 int64 service_worker_registration_id,
138 const std::string& sender_id, 144 const std::string& sender_id,
139 int renderer_id, 145 int renderer_id,
140 int render_frame_id, 146 int render_frame_id,
141 bool user_gesture, 147 bool user_gesture,
142 const content::PushMessagingService::RegisterCallback& callback) { 148 const content::PushMessagingService::RegisterCallback& callback) {
143 if (!gcm_profile_service_->driver()) { 149 if (!gcm_profile_service_->driver()) {
144 NOTREACHED() << "There is no GCMDriver. Has GCMProfileService shut down?"; 150 NOTREACHED() << "There is no GCMDriver. Has GCMProfileService shut down?";
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 sender_ids, 265 sender_ids,
260 base::Bind(&PushMessagingServiceImpl::DidRegister, 266 base::Bind(&PushMessagingServiceImpl::DidRegister,
261 weak_factory_.GetWeakPtr(), 267 weak_factory_.GetWeakPtr(),
262 register_callback)); 268 register_callback));
263 } 269 }
264 270
265 // TODO(johnme): Unregister should decrement the pref, and call 271 // TODO(johnme): Unregister should decrement the pref, and call
266 // RemoveAppHandler if the count drops to zero. 272 // RemoveAppHandler if the count drops to zero.
267 273
268 } // namespace gcm 274 } // namespace gcm
OLDNEW
« no previous file with comments | « chrome/browser/services/gcm/push_messaging_service_impl.h ('k') | components/gcm_driver/default_gcm_app_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698