Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: components/gcm_driver/default_gcm_app_handler.cc

Issue 442123003: [GCM] Adding the OnSendAcknowledgement event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/default_gcm_app_handler.cc
diff --git a/components/gcm_driver/default_gcm_app_handler.cc b/components/gcm_driver/default_gcm_app_handler.cc
index 2e745a031c8fac5d4a7699181be01d22eec47c93..47bd33c2404d0012958971145177d340104730d2 100644
--- a/components/gcm_driver/default_gcm_app_handler.cc
+++ b/components/gcm_driver/default_gcm_app_handler.cc
@@ -37,6 +37,12 @@ void DefaultGCMAppHandler::OnSendError(
<< app_id;
}
+void DefaultGCMAppHandler::OnSendAcknowledged(const std::string& app_id,
+ const std::string& message_id) {
+ LOG(ERROR) << "No app handler is found to route send acknoledgement for "
Nicolas Zea 2014/08/05 23:39:48 Will this get hit if we send a message after unins
fgorski 2014/08/06 16:22:27 Done. That is a valid scenario, and I updated the
+ << app_id;
+}
+
void DefaultGCMAppHandler::OnConnected(const net::IPEndPoint& ip_endpoint) {
// TODO(semenzato): update CrOS NIC state.
DVLOG(1) << "GCM connected to " << ip_endpoint.ToString();

Powered by Google App Engine
This is Rietveld 408576698