Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: components/gcm_driver/default_gcm_app_handler.cc

Issue 442123003: [GCM] Adding the OnSendAcknowledgement event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/gcm_driver/default_gcm_app_handler.h" 5 #include "components/gcm_driver/default_gcm_app_handler.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "net/base/ip_endpoint.h" 8 #include "net/base/ip_endpoint.h"
9 9
10 namespace gcm { 10 namespace gcm {
(...skipping 19 matching lines...) Expand all
30 << app_id; 30 << app_id;
31 } 31 }
32 32
33 void DefaultGCMAppHandler::OnSendError( 33 void DefaultGCMAppHandler::OnSendError(
34 const std::string& app_id, 34 const std::string& app_id,
35 const GCMClient::SendErrorDetails& send_error_details) { 35 const GCMClient::SendErrorDetails& send_error_details) {
36 LOG(ERROR) << "No app handler is found to route send error message for " 36 LOG(ERROR) << "No app handler is found to route send error message for "
37 << app_id; 37 << app_id;
38 } 38 }
39 39
40 void DefaultGCMAppHandler::OnSendAcknowledged(const std::string& app_id,
41 const std::string& message_id) {
42 LOG(ERROR) << "No app handler is found to route send acknoledgement for "
Nicolas Zea 2014/08/05 23:39:48 Will this get hit if we send a message after unins
fgorski 2014/08/06 16:22:27 Done. That is a valid scenario, and I updated the
43 << app_id;
44 }
45
40 void DefaultGCMAppHandler::OnConnected(const net::IPEndPoint& ip_endpoint) { 46 void DefaultGCMAppHandler::OnConnected(const net::IPEndPoint& ip_endpoint) {
41 // TODO(semenzato): update CrOS NIC state. 47 // TODO(semenzato): update CrOS NIC state.
42 DVLOG(1) << "GCM connected to " << ip_endpoint.ToString(); 48 DVLOG(1) << "GCM connected to " << ip_endpoint.ToString();
43 } 49 }
44 50
45 void DefaultGCMAppHandler::OnDisconnected() { 51 void DefaultGCMAppHandler::OnDisconnected() {
46 // TODO(semenzato): update CrOS NIC state. 52 // TODO(semenzato): update CrOS NIC state.
47 DVLOG(1) << "GCM disconnected"; 53 DVLOG(1) << "GCM disconnected";
48 } 54 }
49 55
50 } // namespace gcm 56 } // namespace gcm
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698