Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 442023002: [MIPS64] Adding build support for MIPS64 to libvpx in Chromium (Closed)

Created:
6 years, 4 months ago by gordanac
Modified:
6 years, 1 month ago
Reviewers:
Tom Finegan, gordana.cmiljanovic
CC:
wwcv, jzern, fgalligan1, Tom Finegan, gordana.cmiljanovic_imgtec.com
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Visibility:
Public.

Description

[MIPS64] Adding build support for MIPS64 to libvpx in Chromium Build support for MIPS64 is pulled to libvpx sources from upstream: https://chromium.googlesource.com/chromium/deps/libvpx/ +/ace65784417788374f0b19ce5a8abd06c9ccd007 Here just updated generate_gypi.sh script and run it. BUG=400684

Patch Set 1 #

Patch Set 2 : Update change after libvpx pull from upstream. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M generate_gypi.sh View 1 7 chunks +8 lines, -3 lines 0 comments Download
M libvpx.gyp View 1 2 chunks +4 lines, -3 lines 0 comments Download
A + source/config/linux/mips64el/vp8_rtcd.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/config/linux/mips64el/vp9_rtcd.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/config/linux/mips64el/vpx_config.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + source/config/linux/mips64el/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
A + source/config/linux/mips64el/vpx_rtcd.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/config/linux/mips64el/vpx_scale_rtcd.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
gordanac
Please take a look.
6 years, 4 months ago (2014-08-05 17:02:10 UTC) #1
gordanac
Please take a look to the new page set. Thank you.
6 years, 3 months ago (2014-09-03 15:00:37 UTC) #2
Tom Finegan
lgtm
6 years, 3 months ago (2014-09-04 01:17:39 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 3 months ago (2014-09-04 08:39:28 UTC) #6
gordanac
On 2014/09/04 08:39:28, I haz the power (commit-bot) wrote: > Commit queue rejected this change ...
6 years, 3 months ago (2014-09-04 09:10:41 UTC) #7
Johann
On 2014/09/04 09:10:41, gordanac wrote: > On 2014/09/04 08:39:28, I haz the power (commit-bot) wrote: ...
6 years, 3 months ago (2014-09-04 15:36:10 UTC) #8
gordanac
On 2014/09/04 15:36:10, Johann wrote: > On 2014/09/04 09:10:41, gordanac wrote: > > On 2014/09/04 ...
6 years, 3 months ago (2014-09-04 15:41:27 UTC) #9
Johann
On 2014/09/04 15:41:27, gordanac wrote: > On 2014/09/04 15:36:10, Johann wrote: > > On 2014/09/04 ...
6 years, 3 months ago (2014-09-04 15:45:49 UTC) #10
gordanac
On 2014/09/04 15:45:49, Johann wrote: > On 2014/09/04 15:41:27, gordanac wrote: > > On 2014/09/04 ...
6 years, 3 months ago (2014-09-04 15:58:22 UTC) #11
Johann
On 2014/09/04 15:58:22, gordanac wrote: > On 2014/09/04 15:45:49, Johann wrote: > > On 2014/09/04 ...
6 years, 3 months ago (2014-09-04 17:35:28 UTC) #12
gordanac
6 years, 3 months ago (2014-09-05 08:07:49 UTC) #13
On 2014/09/04 17:35:28, Johann wrote:
> On 2014/09/04 15:58:22, gordanac wrote:
> > On 2014/09/04 15:45:49, Johann wrote:
> > > On 2014/09/04 15:41:27, gordanac wrote:
> > > > On 2014/09/04 15:36:10, Johann wrote:
> > > > > On 2014/09/04 09:10:41, gordanac wrote:
> > > > > > On 2014/09/04 08:39:28, I haz the power (commit-bot) wrote:
> > > > > > > Commit queue rejected this change because it did not recognize the
> > base
> > > > URL.
> > > > > > > Please commit your change manually.
> > > > > > 
> > > > > > Tom, can someone land this change for me manually?
> > > > > 
> > > > > How did you upload the change? With git or gcl?
> > > > > 
> > > > > With gcl:
> > > > > $ gcl commit <change>
> > > > > 
> > > > > With git:
> > > > > $ git cl dcommit
> > > > 
> > > > I did: git cl upload
> > > 
> > > What happens when you run
> > > $ git cl dcommit
> > 
> > $ git cl dcommit
> > This doesn't appear to be an SVN repository.
> > If your project has a git mirror with an upstream SVN master, you probably
> need
> > to run 'git svn init', see your project's git mirror documentation.
> > If your project has a true writeable upstream repository, you probably want
> > to run 'git cl land' instead.
> > Choose wisely, if you get this wrong, your commit might appear to succeed
but
> > will instead be silently ignored.
> > [Press enter to dcommit or ctrl-C to quit]
> > 
> > OK to continue?
> 
> OK, I can't figure out how to do this through git. I've committed the change
> here:
> https://codereview.chromium.org/539193002

Many thanks Johann!

Powered by Google App Engine
This is Rietveld 408576698