Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 441943002: Remove @@create and don't expose unimplemented symbols (Closed)

Created:
6 years, 4 months ago by rossberg
Modified:
6 years, 4 months ago
CC:
adamk, v8-dev
Project:
v8
Visibility:
Public.

Description

Remove @@create and don't expose unimplemented symbols Also, add some bits missing from turn-on-symbols CL R=adamk@chromium.org, dslomov@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M src/symbol.js View 2 chunks +7 lines, -8 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 4 months ago (2014-08-05 11:34:56 UTC) #1
adamk
lgtm, thanks for the fixes
6 years, 4 months ago (2014-08-05 16:13:32 UTC) #2
rossberg
6 years, 4 months ago (2014-08-06 09:31:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22910 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698