Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: tools/telemetry/telemetry/core/tab_unittest.py

Issue 441873007: Move timeline and importers to use telemetry.value.TraceValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/tab_unittest.py
diff --git a/tools/telemetry/telemetry/core/tab_unittest.py b/tools/telemetry/telemetry/core/tab_unittest.py
index 6f1389ade9be07baf89d742b5d73cf057c483cb9..97a548b5dbf7cc5ec148ade33e9a38729f556e8c 100644
--- a/tools/telemetry/telemetry/core/tab_unittest.py
+++ b/tools/telemetry/telemetry/core/tab_unittest.py
@@ -107,8 +107,8 @@ class TabTest(tab_test_case.TabTestCase):
self._browser.StartTracing()
self._tab.Highlight(bitmap.WEB_PAGE_TEST_ORANGE)
self._tab.ClearHighlight(bitmap.WEB_PAGE_TEST_ORANGE)
- trace_data = self._browser.StopTracing()
- timeline_model = model.TimelineModel(trace_data)
+ trace_value = self._browser.StopTracing()
+ timeline_model = model.TimelineModel(trace_value)
renderer_thread = timeline_model.GetRendererThreadFromTabId(
self._tab.id)
found_video_start_event = False
@@ -137,8 +137,8 @@ class TabTest(tab_test_case.TabTestCase):
first_tab.ExecuteJavaScript('console.timeEnd("first-tab-marker");')
second_tab.ExecuteJavaScript('console.time("second-tab-marker");')
second_tab.ExecuteJavaScript('console.timeEnd("second-tab-marker");')
- trace_data = self._browser.StopTracing()
- timeline_model = model.TimelineModel(trace_data)
+ trace_value = self._browser.StopTracing()
+ timeline_model = model.TimelineModel(trace_value)
# Assert that the renderer_thread of the first tab contains
# 'first-tab-marker'.

Powered by Google App Engine
This is Rietveld 408576698