Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: tools/telemetry/telemetry/core/platform/tracing_controller_backend.py

Issue 441873007: Move timeline and importers to use telemetry.value.TraceValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/platform/tracing_controller_backend.py
diff --git a/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py b/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py
index fe7849f85713258fcb783a00a52f384c14dadfcb..b0e26522ad302c8007bb8dd2cc078b6f2107a30f 100644
--- a/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py
+++ b/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py
@@ -4,7 +4,7 @@
from telemetry.core.platform import tracing_category_filter
from telemetry.core.platform import tracing_options
-
+from telemetry.value import trace as trace_value_module
class TracingControllerBackend(object):
def __init__(self, platform_backend):
@@ -47,14 +47,14 @@ class TracingControllerBackend(object):
if len(self.running_browser_backends) != 1:
raise NotImplementedError()
- result = None
+ builder = trace_value_module.TraceValueBuilder()
if self._current_trace_options.enable_chrome_trace:
browser_backend = self.running_browser_backends[0]
- result = browser_backend.StopTracing()
+ result = browser_backend.StopTracing(builder)
self._current_trace_options = None
self._current_category_filter = None
- return result
+ return builder.AsValue()
def IsChromeTracingSupported(self, browser):
browser_backend = self._platform_backend.GetBackendForBrowser(browser)

Powered by Google App Engine
This is Rietveld 408576698