Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 441683002: Add ManagePasswordsBubbleCocoa and unit tests. (Closed)

Created:
6 years, 4 months ago by dconnelly
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add ManagePasswordsBubbleCocoa and unit tests. BUG=328847 Committed: https://crrev.com/ba2c862492754c3254db8c5650a6193df7019392 Cr-Commit-Position: refs/heads/master@{#291667}

Patch Set 1 #

Patch Set 2 : test that closing through the NSWindow is observed and handled #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm View 2 chunks +3 lines, -1 line 0 comments Download
A chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.h View 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm View 1 2 3 4 1 chunk +98 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa_unittest.mm View 1 1 chunk +93 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dconnelly
6 years, 4 months ago (2014-08-04 13:52:53 UTC) #1
Mike West
Trivial platform-agnostic changes LGTM.
6 years, 4 months ago (2014-08-04 13:57:46 UTC) #2
dconnelly
-rohitrao +shess
6 years, 4 months ago (2014-08-04 15:54:26 UTC) #3
Scott Hess - ex-Googler
lgtm, minor nit. https://codereview.chromium.org/441683002/diff/80001/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm File chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm (right): https://codereview.chromium.org/441683002/diff/80001/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm#newcode51 chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm:51: ManagePasswordsBubbleCocoa* ManagePasswordsBubbleCocoa::bubble_ = NULL; I'd put ...
6 years, 4 months ago (2014-08-22 21:55:30 UTC) #4
dconnelly
https://codereview.chromium.org/441683002/diff/80001/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm File chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm (right): https://codereview.chromium.org/441683002/diff/80001/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm#newcode51 chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm:51: ManagePasswordsBubbleCocoa* ManagePasswordsBubbleCocoa::bubble_ = NULL; On 2014/08/22 21:55:29, Scott Hess ...
6 years, 4 months ago (2014-08-25 09:31:35 UTC) #5
dconnelly
The CQ bit was checked by dconnelly@chromium.org
6 years, 4 months ago (2014-08-25 09:31:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/441683002/100001
6 years, 4 months ago (2014-08-25 09:32:38 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (100001) as 6039a410af90b93471e5bf474ed88020b3a2489b
6 years, 4 months ago (2014-08-25 11:26:17 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:34:01 UTC) #9
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/ba2c862492754c3254db8c5650a6193df7019392
Cr-Commit-Position: refs/heads/master@{#291667}

Powered by Google App Engine
This is Rietveld 408576698