Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm

Issue 441683002: Add ManagePasswordsBubbleCocoa and unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: static Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm b/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm
index 747d16870725612eae4c4b7d4c39be360bd6ccb5..4f9528f932eeb0dba71d014b62ecf36899e5e81b 100644
--- a/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm
+++ b/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm
@@ -7,6 +7,7 @@
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/command_updater.h"
#include "chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h"
+#include "chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.h"
#include "ui/base/l10n/l10n_util_mac.h"
// ManagePasswordsIconCocoa
@@ -58,7 +59,8 @@ void ManagePasswordsDecoration::UpdateVisibleUI() {
if (icon_->state() == password_manager::ui::INACTIVE_STATE) {
SetVisible(false);
SetImage(nil);
- // TODO(dconnelly): Hide the bubble once it is implemented.
+ if (ManagePasswordsBubbleCocoa::instance())
+ ManagePasswordsBubbleCocoa::instance()->Close();
return;
}
SetVisible(true);
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698