Issue 441643009: Merge 285492 "Don't allow null bytes in hosts of host permissions."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 441643009: Merge 285492 "Don't allow null bytes in hosts of host permissions." (Closed)

Created:
6 years, 4 months ago by Yoyo Zhou

Modified:
6 years, 4 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/2062/src/

Project:
chromium

Visibility:
Public.

Merge 285492 "Don't allow null bytes in hosts of host permissions." > Don't allow null bytes in hosts of host permissions. > > BUG=390624 > TEST=Load the sample manifest from the bug, comment #9. It should fail to load. > > Review URL: https://codereview.chromium.org/416263002 TBR=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287396

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -0 lines)			Patch
M	extensions/common/url_pattern.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	extensions/common/url_pattern.cc	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	extensions/common/url_pattern_unittest.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Yoyo Zhou

6 years, 4 months ago (2014-08-04 20:21:07 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r287396 (tree was closed).