Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 416263002: Don't allow null bytes in hosts of host permissions. (Closed)

Created:
6 years, 5 months ago by Yoyo Zhou
Modified:
6 years, 5 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Don't allow null bytes in hosts of host permissions. BUG=390624 TEST=Load the sample manifest from the bug, comment #9. It should fail to load. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285492

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M extensions/common/url_pattern.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/url_pattern.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download
M extensions/common/url_pattern_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yoyo Zhou
6 years, 5 months ago (2014-07-25 00:13:09 UTC) #1
Devlin
lgtm.
6 years, 5 months ago (2014-07-25 00:24:24 UTC) #2
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 5 months ago (2014-07-25 00:25:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/416263002/20001
6 years, 5 months ago (2014-07-25 00:27:13 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 05:45:42 UTC) #5
Message was sent while issue was closed.
Change committed as 285492

Powered by Google App Engine
This is Rietveld 408576698