chrome/browser/ui/passwords/manage_passwords_ui_controller.h - Issue 441643007: ManagePasswordsUIController should make a deep copy of values which it doesn't own.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 441643007: ManagePasswordsUIController should make a deep copy of values which it doesn't own. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

index 9fb6c4ee98483e52be2c7e29f274a223ef6e73ed..d9e9aa2e535d401842993d8c5843bd56eceaf37f 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

@@ -119,7 +119,7 @@ class ManagePasswordsUIController

// ManagePasswordsUIControllerMock.

autofill::ConstPasswordFormMap password_form_map_;

vabr (Chromium) 2014/08/04 15:36:56 This declaration order means, that new_password_fo

vasilii 2014/08/04 16:20:59 Done.

- // We create copies of PasswordForm objects that come in via OnLoginsChanged()

+ // We create copies of PasswordForm objects that come in with unclear lifetime

// and store them in this vector as well as in |password_form_map_| to ensure

// that we destroy them correctly.

ScopedVector<autofill::PasswordForm> new_password_forms_;