ManagePasswordsUIController should make a deep copy of values which it doesn't own.

chrome/browser/ui/passwords/manage_passwords_ui_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_vector.h"
 #include "base/timer/elapsed_timer.h"
@@ skipping 99 matching lines @@
   virtual void NeverSavePasswordInternal();
 
   // content::WebContentsObserver:
   virtual void DidNavigateMainFrame(
       const content::LoadCommittedDetails& details,
       const content::FrameNavigateParams& params) OVERRIDE;
 
   // All previously stored credentials for a specific site.
   // Protected, not private, so we can mess with the value in
   // ManagePasswordsUIControllerMock.
   autofill::ConstPasswordFormMap password_form_map_;

[vabr (Chromium), 2014/08/04 15:36:56]

This declaration order means, that new_password_forms_ get deleted before
password_form_map_ on the controller destruction. That can create dangling
pointers -- please swap the declaration order, and also comment on the fact,
that new_password_forms_ can own what is pointed to by password_form_map_, so if
new_password_forms_ gets cleared, then so needs to be cleared
password_form_map_.

[vasilii, 2014/08/04 16:20:59]

Done.

 
-  // We create copies of PasswordForm objects that come in via OnLoginsChanged()
+  // We create copies of PasswordForm objects that come in with unclear lifetime
   // and store them in this vector as well as in |password_form_map_| to ensure
   // that we destroy them correctly.
   ScopedVector<autofill::PasswordForm> new_password_forms_;
 
   // The current state of the password manager. Protected so we can manipulate
   // the value in tests.
   password_manager::ui::State state_;
 
   // Used to measure the amount of time on a page; if it's less than some
   // reasonable limit, then don't close the bubble upon navigation. We create
@@ skipping 27 matching lines @@
 
   // The origin of the form we're currently dealing with; we'll use this to
   // determine which PasswordStore changes we should care about when updating
   // |password_form_map_|.
   GURL origin_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_