chrome/browser/history/chrome_history_client_factory.cc - Issue 441623002: Eliminate sending NOTIFICATION_TOP_SITES_* from TopSites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/chrome_history_client_factory.cc

Issue 441623002: Eliminate sending NOTIFICATION_TOP_SITES_* from TopSites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moving the WaitTopSitesLoadedObserver to testing_profile Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/history/chrome_history_client_factory.cc

diff --git a/chrome/browser/history/chrome_history_client_factory.cc b/chrome/browser/history/chrome_history_client_factory.cc

index b56a89871228b865c53057e5431467bb56d504e6..8a703277d83cb73aecd0fce52bbbe31d22b8adbc 100644

--- a/chrome/browser/history/chrome_history_client_factory.cc

+++ b/chrome/browser/history/chrome_history_client_factory.cc

@@ -36,7 +36,9 @@ ChromeHistoryClientFactory::~ChromeHistoryClientFactory() {

KeyedService* ChromeHistoryClientFactory::BuildServiceInstanceFor(

content::BrowserContext* context) const {

return new ChromeHistoryClient(

sdefresne 2014/09/04 15:50:01 nit: you can define a profile variable here to avo

nshaik 2014/09/04 18:43:01 Done.

- BookmarkModelFactory::GetForProfile(static_cast<Profile*>(context)));

+ BookmarkModelFactory::GetForProfile(static_cast<Profile*>(context)),

+ static_cast<Profile*>(context),

+ static_cast<Profile*>(context)->GetTopSites());

}

content::BrowserContext* ChromeHistoryClientFactory::GetBrowserContextToUse(

« no previous file with comments | « chrome/browser/history/chrome_history_client.cc ('k') | chrome/browser/history/top_sites.h » ('j') | chrome/test/base/testing_profile.cc » ('J')