Eliminate sending NOTIFICATION_TOP_SITES_* from TopSites

chrome/browser/history/chrome_history_client_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/chrome_history_client_factory.h"
 
 #include "base/memory/singleton.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/history/chrome_history_client.h"
 #include "chrome/browser/profiles/incognito_helpers.h"
@@ skipping 17 matching lines @@
           "ChromeHistoryClient",
           BrowserContextDependencyManager::GetInstance()) {
   DependsOn(BookmarkModelFactory::GetInstance());
 }
 
 ChromeHistoryClientFactory::~ChromeHistoryClientFactory() {
 }
 
 KeyedService* ChromeHistoryClientFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
   return new ChromeHistoryClient(

[sdefresne, 2014/09/04 15:50:01]

nit: you can define a profile variable here to avoid the three static_cast:

Profile* profile = static_cast<Profile*>(context);
return new ChromeHistoryClient(
    BookmarkModelFactory::GetForProfile(profile), profile,
profile->GetTopSites());

[nshaik, 2014/09/04 18:43:01]

Done.

-      BookmarkModelFactory::GetForProfile(static_cast<Profile*>(context)));
+      BookmarkModelFactory::GetForProfile(static_cast<Profile*>(context)),
+      static_cast<Profile*>(context),
+      static_cast<Profile*>(context)->GetTopSites());
 }
 
 content::BrowserContext* ChromeHistoryClientFactory::GetBrowserContextToUse(
     content::BrowserContext* context) const {
   return chrome::GetBrowserContextRedirectedInIncognito(context);
 }
 
 bool ChromeHistoryClientFactory::ServiceIsNULLWhileTesting() const {
   return true;
 }