Eliminate sending NOTIFICATION_TOP_SITES_* from TopSites

chrome/browser/history/top_sites_observer.h

Index: chrome/browser/history/top_sites_observer.h
diff --git a/chrome/browser/history/top_sites_observer.h b/chrome/browser/history/top_sites_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..0b4db09e49bc709c7b96679271cd3285dfc62099
--- /dev/null
+++ b/chrome/browser/history/top_sites_observer.h
@@ -0,0 +1,19 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_HISTORY_TOP_SITES_OBSERVER_H_
+#define CHROME_BROWSER_HISTORY_TOP_SITES_OBSERVER_H_
+
+namespace history {
+class TopSites;
+}
+
+// Interface for TopSitesLoaded and TopSitesChanged

[sdefresne, 2014/08/04 08:47:19]

Please re-word this description. Maybe something along the lines of:

// Interface to receive notifications relating to TopSites.

[nshaik, 2014/08/05 06:38:04]

Done.

+class TopSitesObserver {

[sdefresne, 2014/08/04 08:47:19]

Please put the TopSitesObserver type into the history namespace.

namespace history {
class TopSites;

// Interface for ...
class TopSitesObserver {
...

[nshaik, 2014/08/05 06:38:04]

Done.

+ public:
+  virtual void TopSitesLoaded(history::TopSites* top_sites) = 0;

[sdefresne, 2014/08/04 08:47:19]

Please document (you can take inspiration from the documentation of
NOTIFICATION_TOP_SITES_LOADED).

[nshaik, 2014/08/05 06:38:04]

Done.

+  virtual void TopSitesChanged(history::TopSites* top_sites) = 0;

[sdefresne, 2014/08/04 08:47:19]

Please document (you can take inspiration from the documentation of
NOTIFICATION_TOP_SITES_CHANGED).

[nshaik, 2014/08/05 06:38:04]

Done.

+};
+
+#endif  // CHROME_BROWSER_HISTORY_TOP_SITES_OBSERVER_H_