chrome/browser/history/top_sites_observer.h - Issue 441623002: Eliminate sending NOTIFICATION_TOP_SITES_* from TopSites

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/history/top_sites_observer.h

Issue 441623002: Eliminate sending NOTIFICATION_TOP_SITES_* from TopSites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/history/top_sites_impl_unittest.cc ('K') | « chrome/browser/history/top_sites_impl_unittest.cc ('k') | chrome/test/base/testing_profile.cc » ('j') | chrome/test/base/testing_profile.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_HISTORY_TOP_SITES_OBSERVER_H_

	6 #define CHROME_BROWSER_HISTORY_TOP_SITES_OBSERVER_H_

	7

	8 namespace history {

	9 class TopSites;

	10 }

	11

	12 // Interface for TopSitesLoaded and TopSitesChanged
	sdefresne 2014/08/04 08:47:19 Please re-word this description. Maybe something a Please re-word this description. Maybe something along the lines of: // Interface to receive notifications relating to TopSites. nshaik 2014/08/05 06:38:04 Done. Show quoted text On 2014/08/04 08:47:19, sdefresne wrote: > Please re-word this description. Maybe something along the lines of: > > // Interface to receive notifications relating to TopSites. Done.
	13 class TopSitesObserver {
	sdefresne 2014/08/04 08:47:19 Please put the TopSitesObserver type into the hist Please put the TopSitesObserver type into the history namespace. namespace history { class TopSites; // Interface for ... class TopSitesObserver { ... nshaik 2014/08/05 06:38:04 Done. Show quoted text On 2014/08/04 08:47:19, sdefresne wrote: > Please put the TopSitesObserver type into the history namespace. > > namespace history { > class TopSites; > > // Interface for ... > class TopSitesObserver { > ... Done.
	14 public:

	15 virtual void TopSitesLoaded(history::TopSites* top_sites) = 0;
	sdefresne 2014/08/04 08:47:19 Please document (you can take inspiration from the Please document (you can take inspiration from the documentation of NOTIFICATION_TOP_SITES_LOADED). nshaik 2014/08/05 06:38:04 Done. Show quoted text On 2014/08/04 08:47:19, sdefresne wrote: > Please document (you can take inspiration from the documentation of > NOTIFICATION_TOP_SITES_LOADED). Done.
	16 virtual void TopSitesChanged(history::TopSites* top_sites) = 0;
	sdefresne 2014/08/04 08:47:19 Please document (you can take inspiration from the Please document (you can take inspiration from the documentation of NOTIFICATION_TOP_SITES_CHANGED). nshaik 2014/08/05 06:38:04 Done. Show quoted text On 2014/08/04 08:47:19, sdefresne wrote: > Please document (you can take inspiration from the documentation of > NOTIFICATION_TOP_SITES_CHANGED). Done.
	17 };

	18

	19 #endif // CHROME_BROWSER_HISTORY_TOP_SITES_OBSERVER_H_

OLD	NEW