Issue 44153002: Introduce andps for IA32/X64

Issue 44153002: Introduce andps for IA32/X64 (Closed)

Created:
7 years, 1 month ago by Weiliang

Modified:
7 years, 1 month ago

Reviewers:
Benedikt Meurer, Sven Panne

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Introduce andps for IA32/X64 replace andpd and pand in Math.abs BUG= R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17413

Patch Set 1 #

Total comments: 3

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+124 lines, -109 lines)			Patch
M	src/ia32/assembler-ia32.h	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/ia32/disasm-ia32.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+1 line, -1 line	2 comments	Download
M	src/x64/assembler-x64.h	View	6 chunks	+26 lines, -20 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/x64/disasm-x64.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+1 line, -1 line	1 comment	Download
M	test/cctest/test-disasm-ia32.cc	View	2 chunks	+16 lines, -36 lines	0 comments	Download
M	test/cctest/test-disasm-x64.cc	View	1 chunk	+41 lines, -49 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

Committed patchset #1 manually as r17413 (presubmit successful).

7 years, 1 month ago (2013-10-28 10:38:50 UTC) #3

Benedikt Meurer

https://codereview.chromium.org/44153002/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/44153002/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode3886 src/ia32/lithium-codegen-ia32.cc:3886: __ andps(input_reg, scratch); Why andps and not andpd? https://codereview.chromium.org/44153002/diff/1/src/x64/lithium-codegen-x64.cc ...

7 years, 1 month ago (2013-10-28 11:23:17 UTC) #4

Weiliang

7 years, 1 month ago (2013-10-28 12:41:10 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/44153002/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):

https://codereview.chromium.org/44153002/diff/1/src/ia32/lithium-codegen-ia32...
src/ia32/lithium-codegen-ia32.cc:3886: __ andps(input_reg, scratch);
On 2013/10/28 11:23:18, Benedikt Meurer wrote:
> Why andps and not andpd?

For bit-wise operation, I think there is no much difference between andps and
andpd. But andps is one byte less.

Expand Messages | Collapse Messages