Disallow breakaway from job for unit tests

Disallow breakaway from job for unit tests

BUG=328592, 371406
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288305

[sky, 2014-08-06 17:58:50]

https://codereview.chromium.org/441333002/diff/1/base/test/launcher/test_laun...
File base/test/launcher/test_launcher.cc (right):

https://codereview.chromium.org/441333002/diff/1/base/test/launcher/test_laun...
base/test/launcher/test_launcher.cc:1039: if (allow_breakaway) {
nit: no {}

https://codereview.chromium.org/441333002/diff/1/base/test/launcher/test_laun...
File base/test/launcher/test_launcher.h (right):

https://codereview.chromium.org/441333002/diff/1/base/test/launcher/test_laun...
base/test/launcher/test_launcher.h:97: bool allow_breakaway,
How about a bitmask for these? Multiple boolean parameters are really hard to
follow.

And document what allow_breakaway means.

[Paweł Hajdan Jr., 2014-08-07 12:17:41]

PTAL

https://codereview.chromium.org/441333002/diff/1/base/test/launcher/test_laun...
File base/test/launcher/test_launcher.cc (right):

https://codereview.chromium.org/441333002/diff/1/base/test/launcher/test_laun...
base/test/launcher/test_launcher.cc:1039: if (allow_breakaway) {
On 2014/08/06 17:58:49, sky wrote:
> nit: no {}

Done.

https://codereview.chromium.org/441333002/diff/1/base/test/launcher/test_laun...
File base/test/launcher/test_launcher.h (right):

https://codereview.chromium.org/441333002/diff/1/base/test/launcher/test_laun...
base/test/launcher/test_launcher.h:97: bool allow_breakaway,
On 2014/08/06 17:58:49, sky wrote:
> How about a bitmask for these? Multiple boolean parameters are really hard to
> follow.
> 
> And document what allow_breakaway means.

Done.

[sky, 2014-08-07 16:19:57]

LGTM

https://codereview.chromium.org/441333002/diff/20001/base/test/launcher/test_...
File base/test/launcher/test_launcher.h (right):

https://codereview.chromium.org/441333002/diff/20001/base/test/launcher/test_...
base/test/launcher/test_launcher.h:80: // Flags controlling behavior of
LaunchChildGTestProcess.
nit: style guide says enums are first in a section.

[Paweł Hajdan Jr., 2014-08-08 10:19:10]

https://codereview.chromium.org/441333002/diff/20001/base/test/launcher/test_...
File base/test/launcher/test_launcher.h (right):

https://codereview.chromium.org/441333002/diff/20001/base/test/launcher/test_...
base/test/launcher/test_launcher.h:80: // Flags controlling behavior of
LaunchChildGTestProcess.
On 2014/08/07 16:19:57, sky wrote:
> nit: style guide says enums are first in a section.

Done.

[Paweł Hajdan Jr., 2014-08-08 10:19:46]

Committed patchset #3 manually as 288305 (presubmit successful).