Disallow breakaway from job for unit tests

base/test/launcher/test_launcher.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TEST_LAUNCHER_TEST_LAUNCHER_H_
 #define BASE_TEST_LAUNCHER_TEST_LAUNCHER_H_
 
 #include <set>
 #include <string>
 
@@ skipping 59 matching lines @@
 class TestLauncher {
  public:
   // Constructor. |parallel_jobs| is the limit of simultaneous parallel test
   // jobs.
   TestLauncher(TestLauncherDelegate* launcher_delegate, size_t parallel_jobs);
   ~TestLauncher();
 
   // Runs the launcher. Must be called at most once.
   bool Run() WARN_UNUSED_RESULT;
 
+  // Flags controlling behavior of LaunchChildGTestProcess.

[sky, 2014/08/07 16:19:57]

nit: style guide says enums are first in a section.

[Paweł Hajdan Jr., 2014/08/08 10:19:09]

Done.

+  enum LaunchChildGTestProcessFlags {
+    // Allows usage of job objects on Windows. Helps properly clean up child
+    // processes.
+    USE_JOB_OBJECTS = (1 << 0),
+
+    // Allows breakaway from job on Windows. May result in some child processes
+    // not being properly terminated after launcher dies if these processes
+    // fail to cooperate.
+    ALLOW_BREAKAWAY_FROM_JOB = (1 << 1),
+  };
+
   // Callback called after a child process finishes. First argument is the exit
   // code, second one is child process elapsed time, third one is true if
   // the child process was terminated because of a timeout, and fourth one
   // contains output of the child (stdout and stderr together).
   typedef Callback<void(int, const TimeDelta&, bool, const std::string&)>
       LaunchChildGTestProcessCallback;
 
   // Launches a child process (assumed to be gtest-based binary) using
   // |command_line|. If |wrapper| is not empty, it is prepended to the final
   // command line. If the child process is still running after |timeout|, it
-  // is terminated. |use_job_objects| determines whether job objects are used
-  // on Windows (if unsure pass true). After the child process finishes
-  // |callback| is called on the same thread this method was called.
+  // is terminated. After the child process finishes |callback| is called
+  // on the same thread this method was called.
   void LaunchChildGTestProcess(const CommandLine& command_line,
                                const std::string& wrapper,
                                base::TimeDelta timeout,
-                               bool use_job_objects,
+                               int flags,
                                const LaunchChildGTestProcessCallback& callback);
 
   // Called when a test has finished running.
   void OnTestFinished(const TestResult& result);
 
  private:
   bool Init() WARN_UNUSED_RESULT;
 
   // Runs all tests in current iteration. Uses callbacks to communicate success.
   void RunTests();
@@ skipping 80 matching lines @@
                                  const std::string& full_output);
 
 // Returns command line command line after gtest-specific processing
 // and applying |wrapper|.
 CommandLine PrepareCommandLineForGTest(const CommandLine& command_line,
                                        const std::string& wrapper);
 
 }  // namespace base
 
 #endif  // BASE_TEST_LAUNCHER_TEST_LAUNCHER_H_