Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: cc/resources/video_resource_updater.cc

Issue 441303002: 2D Canvas doesn't blend video with the destination buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: browser test build fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/video_resource_updater.cc
diff --git a/cc/resources/video_resource_updater.cc b/cc/resources/video_resource_updater.cc
index a1286b917b4f2bde8af4248eb7654b2da202db4d..2beb5e8ddcbb9c2e1fa9a94da77e5ee6facd9b88 100644
--- a/cc/resources/video_resource_updater.cc
+++ b/cc/resources/video_resource_updater.cc
@@ -249,10 +249,14 @@ VideoFrameExternalResources VideoResourceUpdater::CreateForSoftwarePlanes(
{
ResourceProvider::ScopedWriteLockSoftware lock(
resource_provider_, plane_resources[0].resource_id);
+ // Use SRC mode so we completely overwrite the buffer because reusing the
danakj 2014/08/06 18:07:16 It's more like Use Src mode to avoid clearing the
dshwang 2014/08/06 18:12:40 Done.
+ // resource among frames.
+ lock.sk_canvas()->clear(SK_ColorTRANSPARENT);
danakj 2014/08/06 18:07:16 Clear isn't needed then anymore right?
dshwang 2014/08/06 18:12:40 Oops, you're right! Done.
video_renderer_->Paint(video_frame.get(),
lock.sk_canvas(),
video_frame->visible_rect(),
- 0xff);
+ 0xff,
+ SkXfermode::kSrc_Mode);
}
RecycleResourceData recycle_data = {
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698