Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: cc/resources/video_resource_updater.cc

Issue 441303002: 2D Canvas doesn't blend video with the destination buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: browser test build fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/video_resource_updater.h" 5 #include "cc/resources/video_resource_updater.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/debug/trace_event.h" 8 #include "base/debug/trace_event.h"
9 #include "cc/output/gl_renderer.h" 9 #include "cc/output/gl_renderer.h"
10 #include "cc/resources/resource_provider.h" 10 #include "cc/resources/resource_provider.h"
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 DCHECK_EQ(plane_resources.size(), 1u); 242 DCHECK_EQ(plane_resources.size(), 1u);
243 DCHECK_EQ(plane_resources[0].resource_format, kRGBResourceFormat); 243 DCHECK_EQ(plane_resources[0].resource_format, kRGBResourceFormat);
244 DCHECK(plane_resources[0].mailbox.IsZero()); 244 DCHECK(plane_resources[0].mailbox.IsZero());
245 245
246 if (!video_renderer_) 246 if (!video_renderer_)
247 video_renderer_.reset(new media::SkCanvasVideoRenderer); 247 video_renderer_.reset(new media::SkCanvasVideoRenderer);
248 248
249 { 249 {
250 ResourceProvider::ScopedWriteLockSoftware lock( 250 ResourceProvider::ScopedWriteLockSoftware lock(
251 resource_provider_, plane_resources[0].resource_id); 251 resource_provider_, plane_resources[0].resource_id);
252 // Use SRC mode so we completely overwrite the buffer because reusing the
danakj 2014/08/06 18:07:16 It's more like Use Src mode to avoid clearing the
dshwang 2014/08/06 18:12:40 Done.
253 // resource among frames.
254 lock.sk_canvas()->clear(SK_ColorTRANSPARENT);
danakj 2014/08/06 18:07:16 Clear isn't needed then anymore right?
dshwang 2014/08/06 18:12:40 Oops, you're right! Done.
252 video_renderer_->Paint(video_frame.get(), 255 video_renderer_->Paint(video_frame.get(),
253 lock.sk_canvas(), 256 lock.sk_canvas(),
254 video_frame->visible_rect(), 257 video_frame->visible_rect(),
255 0xff); 258 0xff,
259 SkXfermode::kSrc_Mode);
256 } 260 }
257 261
258 RecycleResourceData recycle_data = { 262 RecycleResourceData recycle_data = {
259 plane_resources[0].resource_id, 263 plane_resources[0].resource_id,
260 plane_resources[0].resource_size, 264 plane_resources[0].resource_size,
261 plane_resources[0].resource_format, 265 plane_resources[0].resource_format,
262 gpu::Mailbox() 266 gpu::Mailbox()
263 }; 267 };
264 external_resources.software_resources.push_back( 268 external_resources.software_resources.push_back(
265 plane_resources[0].resource_id); 269 plane_resources[0].resource_id);
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 } 395 }
392 396
393 PlaneResource recycled_resource(data.resource_id, 397 PlaneResource recycled_resource(data.resource_id,
394 data.resource_size, 398 data.resource_size,
395 data.resource_format, 399 data.resource_format,
396 data.mailbox); 400 data.mailbox);
397 updater->recycled_resources_.push_back(recycled_resource); 401 updater->recycled_resources_.push_back(recycled_resource);
398 } 402 }
399 403
400 } // namespace cc 404 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698