Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 441133003: Media Galleries: Check for invalid files before passing them to the utility process. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), tzik, Lei Zhang, nhiroki, tommycli, Greg Billock, kinuko+fileapi, rvargas (doing something else)
Project:
chromium
Visibility:
Public.

Description

Media Galleries: Check for invalid files before passing them to the utility process. BUG=399030 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287712

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc View 1 chunk +4 lines, -0 lines 3 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-05 23:33:01 UTC) #1
tommycli
lgtm
6 years, 4 months ago (2014-08-05 23:34:06 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-05 23:37:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/441133003/1
6 years, 4 months ago (2014-08-05 23:39:13 UTC) #4
rvargas (doing something else)
https://codereview.chromium.org/441133003/diff/1/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc File chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc (right): https://codereview.chromium.org/441133003/diff/1/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc#newcode57 chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc:57: IPC::TakeFileHandleForProcess(file_.Pass(), nit: seems better to see if file_.IsValid() instead.
6 years, 4 months ago (2014-08-05 23:40:19 UTC) #5
Lei Zhang
https://codereview.chromium.org/441133003/diff/1/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc File chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc (right): https://codereview.chromium.org/441133003/diff/1/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc#newcode57 chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc:57: IPC::TakeFileHandleForProcess(file_.Pass(), On 2014/08/05 23:40:19, rvargas wrote: > nit: seems ...
6 years, 4 months ago (2014-08-05 23:46:38 UTC) #6
rvargas (doing something else)
lgtm https://codereview.chromium.org/441133003/diff/1/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc File chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc (right): https://codereview.chromium.org/441133003/diff/1/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc#newcode57 chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc:57: IPC::TakeFileHandleForProcess(file_.Pass(), On 2014/08/05 23:46:38, Lei Zhang wrote: > ...
6 years, 4 months ago (2014-08-06 00:08:03 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-06 02:54:52 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 06:39:53 UTC) #9
Message was sent while issue was closed. 
Change committed as 287712

Powered by Google App Engine
This is Rietveld 408576698