Media Galleries: Check for invalid files before passing them to the utility process.

chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc

Index: chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc
diff --git a/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc b/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc
index 64c8055b8d06b2eb1309c5f90515e6fb1f8cffdf..24cc894e4021ce7a0058e4a38d7a958e8d7ad45e 100644
--- a/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc
+++ b/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc
@@ -56,6 +56,10 @@ void SafeAudioVideoChecker::OnProcessStarted() {
   IPC::PlatformFileForTransit file_for_transit =
       IPC::TakeFileHandleForProcess(file_.Pass(),

[rvargas (doing something else), 2014/08/05 23:40:19]

nit: seems better to see if file_.IsValid() instead.

[Lei Zhang, 2014/08/05 23:46:38]

We already do that on line 35. I suspect maybe DuplicateHandle() occasionally
fails for whatever reason.

[rvargas (doing something else), 2014/08/06 00:08:03]

You are absolutely right!.

                                     utility_process_host_->GetData().handle);
+  if (file_for_transit == IPC::InvalidPlatformFileForTransit()) {
+    OnCheckingFinished(false /* valid? */);
+    return;
+  }
   const int64 kFileDecodeTimeInMS = 250;
   utility_process_host_->Send(new ChromeUtilityMsg_CheckMediaFile(
       kFileDecodeTimeInMS, file_for_transit));