Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Issue 441025: RESUBMIT of http://codereview.chromium.org/404025/show (Closed)

Created:
11 years ago by chase
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

RESUBMIT of http://codereview.chromium.org/404025/show Start the WebKit thread when we initialize the resource dispatcher host. NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing. TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread. Originally landed in r33063, reverted in r33101 due to coincidence with Modules Linux startup test failures. TBR=jorlow, darin TEST=The WebKit thread gets spun up early in the initialization process. BUG=24144, 28364 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -71 lines) Patch
M chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc View 10 chunks +24 lines, -28 lines 0 comments Download
M chrome/browser/in_process_webkit/webkit_thread.h View 2 chunks +4 lines, -15 lines 0 comments Download
M chrome/browser/in_process_webkit/webkit_thread.cc View 3 chunks +13 lines, -18 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
chase
Lei Zhang investigated the Linux startup test failures and found they were flaky regardless of ...
11 years ago (2009-11-25 22:39:46 UTC) #1
jorlow
11 years ago (2009-11-25 22:44:10 UTC) #2
LGTM

Thanks Chase!

On Wed, Nov 25, 2009 at 5:39 PM, <chase@chromium.org> wrote:

> Reviewers: Jeremy Orlow, darin,
>
> Message:
> Lei Zhang investigated the Linux startup test failures and found they were
> flaky
> regardless of r33063, so I'm relanding this CL on jorlow's behalf.
>
> Description:
> RESUBMIT of http://codereview.chromium.org/404025/show
>
> Start the WebKit thread when we initialize the resource
> dispatcher host.
>
> NOTE: It's very possible this will have a startup
> performance impact. I'm going to watch the bots after
> committing.
>
> TODO: Clean up shutdown logic that exists simply
> because we don't know whether or not we'll ever start
> the WebKit thread.
>
> Originally landed in r33063, reverted in r33101 due to
> coincidence with Modules Linux startup test failures.
>
> TBR=jorlow, darin
> TEST=The WebKit thread gets spun up early in the
> initialization process.
> BUG=24144,28364
>
> Please review this at http://codereview.chromium.org/441025
>
> Affected files:
>  M chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
>  M chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
>  M chrome/browser/in_process_webkit/webkit_thread.h
>  M chrome/browser/in_process_webkit/webkit_thread.cc
>  M chrome/browser/renderer_host/resource_dispatcher_host.cc
>  M chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698