Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2766)

Unified Diff: chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

Issue 441025: RESUBMIT of http://codereview.chromium.org/404025/show (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/resource_dispatcher_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
diff --git a/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc b/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
index 301a2a1c3cd31043bae536121bf068b04169c0ae..4feed717a511d2cb1cb57a75046577b76391dbad 100644
--- a/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
+++ b/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
@@ -320,8 +320,7 @@ void CheckSuccessfulRequest(const std::vector<IPC::Message>& messages,
}
// Tests whether many messages get dispatched properly.
-// TODO(jorlow): Re-enable once bug 28364 is fixed.
-TEST_F(ResourceDispatcherHostTest, DISABLED_TestMany) {
+TEST_F(ResourceDispatcherHostTest, TestMany) {
EXPECT_EQ(0, host_.GetOutstandingRequestsMemoryCost(0));
MakeTestRequest(0, 1, URLRequestTestJob::test_url_1());
@@ -347,8 +346,7 @@ TEST_F(ResourceDispatcherHostTest, DISABLED_TestMany) {
// Tests whether messages get canceled properly. We issue three requests,
// cancel one of them, and make sure that each sent the proper notifications.
-// TODO(jorlow): Re-enable once bug 28364 is fixed.
-TEST_F(ResourceDispatcherHostTest, DISABLED_Cancel) {
+TEST_F(ResourceDispatcherHostTest, Cancel) {
EXPECT_EQ(0, host_.GetOutstandingRequestsMemoryCost(0));
MakeTestRequest(0, 1, URLRequestTestJob::test_url_1());
@@ -608,8 +606,7 @@ TEST_F(ResourceDispatcherHostTest, TestBlockedRequestsProcessDies) {
// away. Note that we rely on Purify for finding the leaks if any.
// If this test turns the Purify bot red, check the ResourceDispatcherHost
// destructor to make sure the blocked requests are deleted.
-// TODO(jorlow): Re-enable once bug 28364 is fixed.
-TEST_F(ResourceDispatcherHostTest, DISABLED_TestBlockedRequestsDontLeak) {
+TEST_F(ResourceDispatcherHostTest, TestBlockedRequestsDontLeak) {
// This second receiver is used to emulate a second process.
ForwardingReceiver second_receiver(this);
« no previous file with comments | « chrome/browser/renderer_host/resource_dispatcher_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698