[Android] Fix type-parameterized gtest parsing.

[Android] Fix type-parameterized gtest parsing.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287701

[jbudorick, 2014-08-05 20:51:14]

(presubmit failure only due to lack of LGTM)

[craigdh, 2014-08-05 20:59:31]

lgtm w/ nits

https://codereview.chromium.org/441023002/diff/1/build/android/pylib/gtest/te...
File build/android/pylib/gtest/test_package.py (right):

https://codereview.chromium.org/441023002/diff/1/build/android/pylib/gtest/te...
build/android/pylib/gtest/test_package.py:92: test_case = test.split(None, 1)[0]
how is this different from test.split()[0]?

https://codereview.chromium.org/441023002/diff/1/build/android/pylib/gtest/te...
build/android/pylib/gtest/test_package.py:95: continue
use an else instead

[jbudorick, 2014-08-05 21:04:10]

https://codereview.chromium.org/441023002/diff/1/build/android/pylib/gtest/te...
File build/android/pylib/gtest/test_package.py (right):

https://codereview.chromium.org/441023002/diff/1/build/android/pylib/gtest/te...
build/android/pylib/gtest/test_package.py:92: test_case = test.split(None, 1)[0]
On 2014/08/05 20:59:31, craigdh wrote:
> how is this different from test.split()[0]?

As before, functionally the same, but it only does one split.

I guess it doesn't really matter, so switching to the simpler one.

https://codereview.chromium.org/441023002/diff/1/build/android/pylib/gtest/te...
build/android/pylib/gtest/test_package.py:95: continue
On 2014/08/05 20:59:31, craigdh wrote:
> use an else instead

Done.

[jbudorick, 2014-08-05 21:08:50]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-08-05 21:10:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/441023002/20001

[craigdh, 2014-08-05 21:23:33]

https://codereview.chromium.org/441023002/diff/1/build/android/pylib/gtest/te...
File build/android/pylib/gtest/test_package.py (right):

https://codereview.chromium.org/441023002/diff/1/build/android/pylib/gtest/te...
build/android/pylib/gtest/test_package.py:92: test_case = test.split(None, 1)[0]
On 2014/08/05 21:04:10, jbudorick wrote:
> On 2014/08/05 20:59:31, craigdh wrote:
> > how is this different from test.split()[0]?
> 
> As before, functionally the same, but it only does one split.
> 
> I guess it doesn't really matter, so switching to the simpler one.

Ah, I never saw your response to the other one. I like erring on the side of
readability for Python when it's as minor of a perf tradeoff as this (I had to
go to pydoc to remember the order of params for split :)

[commit-bot: I haz the power, 2014-08-06 00:38:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-06 01:11:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-06 01:11:09]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[jbudorick, 2014-08-06 01:13:31]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-08-06 01:15:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/441023002/20001

[commit-bot: I haz the power, 2014-08-06 06:16:22]

Change committed as 287701