Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3958)

Unified Diff: build/android/pylib/gtest/test_package.py

Issue 441023002: [Android] Fix type-parameterized gtest parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments from craigdh Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/gtest/test_package_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/gtest/test_package.py
diff --git a/build/android/pylib/gtest/test_package.py b/build/android/pylib/gtest/test_package.py
index fcc53b7b092d401e74cf7b02958fa072fa17cf23..a0a6b645c83fff72ec1b02dd9760659143354677 100644
--- a/build/android/pylib/gtest/test_package.py
+++ b/build/android/pylib/gtest/test_package.py
@@ -88,14 +88,11 @@ class TestPackage(object):
for test in raw_list:
if not test:
continue
- if test[0] != ' ' and not test.endswith('.'):
- # Ignore any lines with unexpected format.
- continue
- if test[0] != ' ' and test.endswith('.'):
- current = test
- continue
- if 'YOU HAVE' in test:
- break
- test_name = test.split(None, 1)[0]
- ret += [current + test_name]
+ if test[0] != ' ':
+ test_case = test.split()[0]
+ if test_case.endswith('.'):
+ current = test_case
+ elif not 'YOU HAVE' in test:
+ test_name = test.split()[0]
+ ret += [current + test_name]
return ret
« no previous file with comments | « no previous file | build/android/pylib/gtest/test_package_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698