Issue 441005: Stab-in-the-dark at fixing a top crasher. GetCurrentRenderView() can

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 441005: Stab-in-the-dark at fixing a top crasher. GetCurrentRenderView() can (Closed)

Created:
11 years, 1 month ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Stab-in-the-dark at fixing a top crasher. GetCurrentRenderView() can actually return NULL, which means that GetExtensionIdForCurrentContext() can also return empty string. Hillarity ensues. BUG=28487 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33034

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -9 lines)			Patch
	M	chrome/renderer/extensions/extension_process_bindings.cc	View		5 chunks	+26 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages