Stab-in-the-dark at fixing a top crasher. GetCurrentRenderView() can

chrome/renderer/extensions/extension_process_bindings.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/extension_process_bindings.h"
 
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 186 matching lines @@
     for (size_t i = 0; i < names.size(); ++i) {
       name_set->insert(names[i]);
     }
   }
 
   // Note: do not call this function before or during the chromeHidden.onLoad
   // event dispatch. The URL might not have been committed yet and might not
   // be an extension URL.
   static std::string ExtensionIdForCurrentContext() {
     RenderView* renderview = bindings_utils::GetRenderViewForCurrentContext();
-    DCHECK(renderview);
+    if (!renderview)
+      return std::string();  // this can happen as a tab is closing.
+
     GURL url = renderview->webview()->mainFrame()->url();
-    if (url.SchemeIs(chrome::kExtensionScheme))
-      return url.host();
-    return std::string();
+    if (!url.SchemeIs(chrome::kExtensionScheme))
+      return std::string();
+
+    return url.host();
   }
 
   virtual v8::Handle<v8::FunctionTemplate> GetNativeFunction(
       v8::Handle<v8::String> name) {
     if (name->Equals(v8::String::New("GetExtensionAPIDefinition"))) {
       return v8::FunctionTemplate::New(GetExtensionAPIDefinition);
     } else if (name->Equals(v8::String::New("GetExtensionViews"))) {
       return v8::FunctionTemplate::New(GetExtensionViews);
     } else if (name->Equals(v8::String::New("GetNextRequestId"))) {
       return v8::FunctionTemplate::New(GetNextRequestId);
@@ skipping 43 matching lines @@
 
     // Disallow searching for a host view if we are a popup view, and likewise
     // if we are a toolstrip view.
     RenderView* render_view = bindings_utils::GetRenderViewForCurrentContext();
     if (!render_view ||
         render_view->view_type() == viewtype_to_find) {
       return v8::Undefined();
     }
 
     int browser_window_id = render_view->browser_window_id();
-    ExtensionViewAccumulator  popup_matcher(ExtensionIdForCurrentContext(),
+    std::string extension_id = ExtensionIdForCurrentContext();
+    if (extension_id.empty())
+      return v8::Undefined();
+
+    ExtensionViewAccumulator  popup_matcher(extension_id,
                                             browser_window_id,
                                             viewtype_to_find);
     RenderView::ForEach(&popup_matcher);
 
     if (0 == popup_matcher.views()->Length())
       return v8::Undefined();
     DCHECK(popup_matcher.views()->Has(0));
 
     // Return the first view found.
     return popup_matcher.views()->Get(v8::Integer::New(0));
@@ skipping 28 matching lines @@
     } else if (view_type_string == ViewType::kBackgroundPage) {
       view_type = ViewType::EXTENSION_BACKGROUND_PAGE;
     } else if (view_type_string == ViewType::kTabContents) {
       view_type = ViewType::TAB_CONTENTS;
     } else if (view_type_string == ViewType::kPopup) {
       view_type = ViewType::EXTENSION_POPUP;
     } else if (view_type_string != ViewType::kAll) {
       return v8::Undefined();
     }
 
-    ExtensionViewAccumulator accumulator(
-        ExtensionIdForCurrentContext(), browser_window_id, view_type);
+    std::string extension_id = ExtensionIdForCurrentContext();
+    if (extension_id.empty())
+      return v8::Undefined();
+
+    ExtensionViewAccumulator accumulator(extension_id, browser_window_id,
+                                         view_type);
     RenderView::ForEach(&accumulator);
     return accumulator.views();
   }
 
   static v8::Handle<v8::Value> GetNextRequestId(const v8::Arguments& args) {
     static int next_request_id = 0;
     return v8::Integer::New(next_request_id++);
   }
 
   // Creates a new messaging channel to the tab with the given ID.
@@ skipping 40 matching lines @@
 
     return page_action_vector;
   }
 
   static v8::Handle<v8::Value> GetL10nMessage(const v8::Arguments& args) {
     if (args.Length() != 2 || !args[0]->IsString()) {
       NOTREACHED() << "Bad arguments";
       return v8::Undefined();
     }
 
-    L10nMessagesMap* l10n_messages =
-      GetL10nMessagesMap(ExtensionIdForCurrentContext());
+    std::string extension_id = ExtensionIdForCurrentContext();
+    if (extension_id.empty())
+      return v8::Undefined();
+
+    L10nMessagesMap* l10n_messages = GetL10nMessagesMap(extension_id);
     if (!l10n_messages)
       return v8::Undefined();
 
     std::string message_name = *v8::String::AsciiValue(args[0]);
     std::string message =
       ExtensionMessageBundle::GetL10nMessage(message_name, *l10n_messages);
 
     std::vector<std::string> substitutions;
     if (args[1]->IsNull() || args[1]->IsUndefined()) {
       // chrome.i18n.getMessage("message_name");
@@ skipping 236 matching lines @@
   std::string permission_name = function_name.substr(0, first_dot);
   if (permission_name == "windows")
     return "tabs";  // windows and tabs are the same permission.
   return permission_name;
 }
 
 // static
 bool ExtensionProcessBindings::CurrentContextHasPermission(
     const std::string& function_name) {
   std::string extension_id = ExtensionImpl::ExtensionIdForCurrentContext();
+  if (extension_id.empty())
+    return false;
+
   PermissionsMap& permissions_map = *GetPermissionsMap(extension_id);
   std::string permission_name = GetPermissionName(function_name);
   PermissionsMap::iterator it = permissions_map.find(permission_name);
 
   // We explicitly check if the permission entry is present and false, because
   // some APIs do not have a required permission entry (ie, "chrome.extension").
   return (it == permissions_map.end() || it->second);
 }
 
 // static
@@ skipping 24 matching lines @@
     return;
 
   v8::HandleScope handle_scope;
   WebFrame* frame = view->mainFrame();
   v8::Local<v8::Context> context = frame->mainWorldScriptContext();
   v8::Handle<v8::Value> argv[1];
   argv[0] = v8::String::New(type_str);
   bindings_utils::CallFunctionInContext(context, "setViewType",
                                         arraysize(argv), argv);
 }