Add RECORD_AS_MUCH_AS_POSSIBLE mode to TraceOptions.

Add RECORD_AS_MUCH_AS_POSSIBLE mode to TraceOptions.

With current implementation of devtool_tracing_handler, it doesn't do 
anything with invalid options and just use RECORD_UNTIL_FULL by default. So
the change to telemetry's tracing backend will not break backward
compatibility for browsers that don't support "record-as-much-as-possible" option.

However, this is a hacky way to maintain backward compatibility, and we 
should fix devtool_tracing_handler so it can respond with error message on
Tracing.start if there is options parsing error.

BUG=396081
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288047

[nduca, 2014-08-05 22:50:31]

lgtm without telemetry change

https://codereview.chromium.org/440903003/diff/20001/content/browser/devtools...
File content/browser/devtools/devtools_tracing_handler.cc (right):

https://codereview.chromium.org/440903003/diff/20001/content/browser/devtools...
content/browser/devtools/devtools_tracing_handler.cc:139:
base::SplitString(options, ',', &split);
we probably should add handling and make the request fail. that could be a
followup bug though.

https://codereview.chromium.org/440903003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right):

https://codereview.chromium.org/440903003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:136:
self._CheckNotificationSupported()
instead of this, land the c+++ changes without any python changes. then
tomorrow, get the branch number from $src/VERSION. then do a telemetry patch
that does the right thing based on the brower_backend.chrome_branch_number.

[nednguyen, 2014-08-05 23:05:40]

https://codereview.chromium.org/440903003/diff/20001/content/browser/devtools...
File content/browser/devtools/devtools_tracing_handler.cc (right):

https://codereview.chromium.org/440903003/diff/20001/content/browser/devtools...
content/browser/devtools/devtools_tracing_handler.cc:139:
base::SplitString(options, ',', &split);
On 2014/08/05 22:50:31, nduca wrote:
> we probably should add handling and make the request fail. that could be a
> followup bug though.

Acknowledged.

https://codereview.chromium.org/440903003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right):

https://codereview.chromium.org/440903003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:136:
self._CheckNotificationSupported()
On 2014/08/05 22:50:31, nduca wrote:
> instead of this, land the c+++ changes without any python changes. then
> tomorrow, get the branch number from $src/VERSION. then do a telemetry patch
> that does the right thing based on the brower_backend.chrome_branch_number.

Done.

[nednguyen, 2014-08-05 23:05:43]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-08-05 23:08:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nednguyen@google.com/440903003/40001

[commit-bot: I haz the power, 2014-08-06 04:23:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-06 04:27:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-06 04:27:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nednguyen, 2014-08-06 16:22:13]

On 2014/08/06 04:27:46, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

+yurys for change to devtools_tracing_handler.cc

[yurys, 2014-08-07 08:55:34]

devtools_tracing_handler.cc - lgtm

[nednguyen, 2014-08-07 13:15:40]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-08-07 13:16:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nednguyen@google.com/440903003/40001

[commit-bot: I haz the power, 2014-08-07 15:41:17]

Change committed as 288047