Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: base/debug/trace_event_impl.cc

Issue 440903003: Add RECORD_AS_MUCH_AS_POSSIBLE mode to TraceOptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert telemetry change Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/trace_event_impl.h ('k') | base/debug/trace_event_impl_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/trace_event_impl.cc
diff --git a/base/debug/trace_event_impl.cc b/base/debug/trace_event_impl.cc
index 85fa692ca781ad6caaf5bbfa8845020b33cdf7c8..a9f058324c71491b82195370b4a6370b960f196a 100644
--- a/base/debug/trace_event_impl.cc
+++ b/base/debug/trace_event_impl.cc
@@ -61,6 +61,7 @@ const int kOverheadReportThresholdInMicroseconds = 50;
// String options that can be used to initialize TraceOptions.
const char kRecordUntilFull[] = "record-until-full";
const char kRecordContinuously[] = "record-continuously";
+const char kRecordAsMuchAsPossible[] = "record-as-much-as-possible";
const char kTraceToConsole[] = "trace-to-console";
const char kEnableSampling[] = "enable-sampling";
const char kEnableSystrace[] = "enable-systrace";
@@ -68,6 +69,8 @@ const char kEnableSystrace[] = "enable-systrace";
// Controls the number of trace events we will buffer in-memory
// before throwing them away.
const size_t kTraceBufferChunkSize = TraceBufferChunk::kTraceBufferChunkSize;
+const size_t kTraceEventVectorBigBufferChunks =
+ 512000000 / kTraceBufferChunkSize;
const size_t kTraceEventVectorBufferChunks = 256000 / kTraceBufferChunkSize;
const size_t kTraceEventRingBufferChunks = kTraceEventVectorBufferChunks / 4;
const size_t kTraceEventBatchChunks = 1000 / kTraceBufferChunkSize;
@@ -996,6 +999,8 @@ TraceOptions::TraceOptions(const std::string& options_string)
record_mode = RECORD_CONTINUOUSLY;
} else if (*iter == kTraceToConsole) {
record_mode = ECHO_TO_CONSOLE;
+ } else if (*iter == kRecordAsMuchAsPossible) {
+ record_mode = RECORD_AS_MUCH_AS_POSSIBLE;
} else if (*iter == kEnableSampling) {
enable_sampling = true;
} else if (*iter == kEnableSystrace) {
@@ -1018,6 +1023,9 @@ std::string TraceOptions::ToString() const {
case ECHO_TO_CONSOLE:
ret = kTraceToConsole;
break;
+ case RECORD_AS_MUCH_AS_POSSIBLE:
+ ret = kRecordAsMuchAsPossible;
+ break;
default:
NOTREACHED();
}
@@ -1478,6 +1486,8 @@ TraceLog::InternalTraceOptions TraceLog::GetInternalOptionsFromTraceOptions(
return ret | kInternalRecordContinuously;
case ECHO_TO_CONSOLE:
return ret | kInternalEchoToConsole;
+ case RECORD_AS_MUCH_AS_POSSIBLE:
+ return ret | kInternalRecordAsMuchAsPossible;
}
NOTREACHED();
return kInternalNone;
@@ -1498,6 +1508,8 @@ TraceOptions TraceLog::GetCurrentTraceOptions() const {
ret.record_mode = RECORD_CONTINUOUSLY;
else if (option & kInternalEchoToConsole)
ret.record_mode = ECHO_TO_CONSOLE;
+ else if (option & kInternalRecordAsMuchAsPossible)
+ ret.record_mode = RECORD_AS_MUCH_AS_POSSIBLE;
else
NOTREACHED();
return ret;
@@ -1599,6 +1611,8 @@ TraceBuffer* TraceLog::CreateTraceBuffer() {
return new TraceBufferRingBuffer(kMonitorTraceEventBufferChunks);
else if (options & kInternalEchoToConsole)
return new TraceBufferRingBuffer(kEchoToConsoleTraceEventBufferChunks);
+ else if (options & kInternalRecordAsMuchAsPossible)
+ return CreateTraceBufferVectorOfSize(kTraceEventVectorBigBufferChunks);
return CreateTraceBufferVectorOfSize(kTraceEventVectorBufferChunks);
}
« no previous file with comments | « base/debug/trace_event_impl.h ('k') | base/debug/trace_event_impl_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698