Consistancy in AccumulatePropertyUpdates for Animation Computation

cc: consistancy of variable usage in 
LayerAnimationController::AccumulatePropertyUpdates

The animation value is computed from the animation curve. The general
format used is to get the specific animation curve into one variable 
and then use the getvalue to get the actual animation value. The same
is followed across the file except in AccumulatePropertyUpdates. 
This patch takes cares of the same.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287551

[shreyas.g, 2014-08-05 12:58:15]

PTAL

[ajuma, 2014-08-05 13:10:17]

On 2014/08/05 12:58:15, shreyas.g wrote:
> PTAL

lgtm

[danakj, 2014-08-05 13:11:12]

Why do this? It seems harder to read to me. What's wrong with an intermediate
variable?

[ajuma, 2014-08-05 13:18:23]

On 2014/08/05 13:11:12, danakj_OOO_until_Aug_3 wrote:
> Why do this? It seems harder to read to me. What's wrong with an intermediate
> variable?

Good point. I think the main argument in favor of this is consistency with
AccumulatePropertyUpdates, but maybe a better way to get this consistency is to
add an intermediate variable in AccumulatePropertyUpdates rather than removing
the intermediate variable here.

[shreyas.g, 2014-08-05 13:34:30]

On 2014/08/05 13:18:23, ajuma wrote:
> On 2014/08/05 13:11:12, danakj_OOO_until_Aug_3 wrote:
> > Why do this? It seems harder to read to me. What's wrong with an
intermediate
> > variable?
> 
> Good point. I think the main argument in favor of this is consistency with
> AccumulatePropertyUpdates, but maybe a better way to get this consistency is
to
> add an intermediate variable in AccumulatePropertyUpdates rather than removing
> the intermediate variable here.

[shreyas.g, 2014-08-05 13:49:11]

On 2014/08/05 13:34:30, shreyas.g wrote:
> On 2014/08/05 13:18:23, ajuma wrote:
> > On 2014/08/05 13:11:12, danakj_OOO_until_Aug_3 wrote:
> > > Why do this? It seems harder to read to me. What's wrong with an
> intermediate
> > > variable?
> > 
> > Good point. I think the main argument in favor of this is consistency with
> > AccumulatePropertyUpdates, but maybe a better way to get this consistency is
> to
> > add an intermediate variable in AccumulatePropertyUpdates rather than
removing
> > the intermediate variable here.

Hi Dana/Ajuma,

Yeah, the main reason was for the consistancy, and it does make sense 
to have intermediate variable for readability. Moreoever when I check 
apart from AccumulatePropertyUpdates all other occurances use the 
intermediate variables to have better understanding. I will try to 
follow the same. Thanks for reviewing.

[shreyas.g, 2014-08-05 14:09:10]

On 2014/08/05 13:49:11, shreyas.g wrote:
> On 2014/08/05 13:34:30, shreyas.g wrote:
> > On 2014/08/05 13:18:23, ajuma wrote:
> > > On 2014/08/05 13:11:12, danakj_OOO_until_Aug_3 wrote:
> > > > Why do this? It seems harder to read to me. What's wrong with an
> > intermediate
> > > > variable?
> > > 
> > > Good point. I think the main argument in favor of this is consistency with
> > > AccumulatePropertyUpdates, but maybe a better way to get this consistency
is
> > to
> > > add an intermediate variable in AccumulatePropertyUpdates rather than
> removing
> > > the intermediate variable here.
> 
> Hi Dana/Ajuma,
> 
> Yeah, the main reason was for the consistancy, and it does make sense 
> to have intermediate variable for readability. Moreoever when I check 
> apart from AccumulatePropertyUpdates all other occurances use the 
> intermediate variables to have better understanding. I will try to 
> follow the same. Thanks for reviewing.

PTAL. Changed the description as well.

[ajuma, 2014-08-05 14:30:58]

On 2014/08/05 14:09:10, shreyas.g wrote:
> On 2014/08/05 13:49:11, shreyas.g wrote:
> > On 2014/08/05 13:34:30, shreyas.g wrote:
> > > On 2014/08/05 13:18:23, ajuma wrote:
> > > > On 2014/08/05 13:11:12, danakj_OOO_until_Aug_3 wrote:
> > > > > Why do this? It seems harder to read to me. What's wrong with an
> > > intermediate
> > > > > variable?
> > > > 
> > > > Good point. I think the main argument in favor of this is consistency
with
> > > > AccumulatePropertyUpdates, but maybe a better way to get this
consistency
> is
> > > to
> > > > add an intermediate variable in AccumulatePropertyUpdates rather than
> > removing
> > > > the intermediate variable here.
> > 
> > Hi Dana/Ajuma,
> > 
> > Yeah, the main reason was for the consistancy, and it does make sense 
> > to have intermediate variable for readability. Moreoever when I check 
> > apart from AccumulatePropertyUpdates all other occurances use the 
> > intermediate variables to have better understanding. I will try to 
> > follow the same. Thanks for reviewing.
> 
> PTAL. Changed the description as well.

lgtm

[shreyas.g, 2014-08-05 14:31:57]

The CQ bit was checked by shreyas.g@samsung.com

[commit-bot: I haz the power, 2014-08-05 14:33:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shreyas.g@samsung.com/440873002/20001

[commit-bot: I haz the power, 2014-08-05 16:36:20]

Change committed as 287551