Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2128)

Unified Diff: cc/animation/layer_animation_controller.cc

Issue 440873002: Consistancy in AccumulatePropertyUpdates for Animation Computation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added variables to AccumulatePropertyUpdates to maintain consistancy Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/animation/layer_animation_controller.cc
diff --git a/cc/animation/layer_animation_controller.cc b/cc/animation/layer_animation_controller.cc
index 0088c3dde8ed422451abc14a11f5059fa7df5a55..25941bbffc4016183979ca34a41213a9c06534ff 100644
--- a/cc/animation/layer_animation_controller.cc
+++ b/cc/animation/layer_animation_controller.cc
@@ -152,8 +152,9 @@ void LayerAnimationController::AccumulatePropertyUpdates(
animation->group(),
Animation::Opacity,
monotonic_time);
- event.opacity = animation->curve()->ToFloatAnimationCurve()->GetValue(
- trimmed);
+ const FloatAnimationCurve* float_animation_curve =
+ animation->curve()->ToFloatAnimationCurve();
+ event.opacity = float_animation_curve->GetValue(trimmed);
event.is_impl_only = true;
events->push_back(event);
break;
@@ -165,8 +166,9 @@ void LayerAnimationController::AccumulatePropertyUpdates(
animation->group(),
Animation::Transform,
monotonic_time);
- event.transform =
- animation->curve()->ToTransformAnimationCurve()->GetValue(trimmed);
+ const TransformAnimationCurve* transform_animation_curve =
+ animation->curve()->ToTransformAnimationCurve();
+ event.transform = transform_animation_curve->GetValue(trimmed);
event.is_impl_only = true;
events->push_back(event);
break;
@@ -178,8 +180,9 @@ void LayerAnimationController::AccumulatePropertyUpdates(
animation->group(),
Animation::Filter,
monotonic_time);
- event.filters = animation->curve()->ToFilterAnimationCurve()->GetValue(
- trimmed);
+ const FilterAnimationCurve* filter_animation_curve =
+ animation->curve()->ToFilterAnimationCurve();
+ event.filters = filter_animation_curve->GetValue(trimmed);
event.is_impl_only = true;
events->push_back(event);
break;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698