chrome/test/data/extensions/api_test/media_galleries/gallerywatch/manifest.json - Issue 440813002: Expose gallery watching functionality to the public mediaGalleries API.

Unified Diff: chrome/test/data/extensions/api_test/media_galleries/gallerywatch/manifest.json

Issue 440813002: Expose gallery watching functionality to the public mediaGalleries API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup the code and prepare for review. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc ('K') | « chrome/common/extensions/api/media_galleries.idl ('k') | chrome/test/data/extensions/api_test/media_galleries/gallerywatch/test.js » ('j') | chrome/test/data/extensions/api_test/media_galleries/gallerywatch/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/media_galleries/gallerywatch/manifest.json

diff --git a/chrome/test/data/extensions/api_test/media_galleries_private/gallerywatch/manifest.json b/chrome/test/data/extensions/api_test/media_galleries/gallerywatch/manifest.json

similarity index 85%

copy from chrome/test/data/extensions/api_test/media_galleries_private/gallerywatch/manifest.json

copy to chrome/test/data/extensions/api_test/media_galleries/gallerywatch/manifest.json

index 67cd894ad1cebf152c0e77f05ec2574fa3df45e5..16c5a044d433c96ecb78cd2e3434dacdd3e294d0 100644

--- a/chrome/test/data/extensions/api_test/media_galleries_private/gallerywatch/manifest.json

+++ b/chrome/test/data/extensions/api_test/media_galleries/gallerywatch/manifest.json

@@ -2,11 +2,11 @@

"key": "MIICeAIBADANBgkqhkiG9w0BAQEFAASCAmIwggJeAgEAAoGBAO3OlBjA3w16pm0kjJJDYIua1wEIYLjEi+VhfHw28OW+49ekz3qms9PmFfZvJCAOJEC1lPNj4ZROG3qBE4JEJ6IgeP5tF4fSdie6kL6VOH6tiDHe/ozI5gwcOMXIa9x8nyVyHwozBKMHQTT4ZNFhjbhkxyGYixhkOnk1GOHPiMxXAgMBAAECgYEA6Hrs0yoypRXDf62ccxzFVJWCHXNYQyl6bjuYnEKFzMSKL3Xik9BGuyATVoCeu2u3yz75J9v8WqTlPiTTsqT4bCeC4r1RGDmnS4gftWVKqHpl/HhVKRFvtu5wlPL9jdECnZdB7Viro0k8LqOqOUG2rPbKeK1JolKQEKp+Zc7u6SkCQQD6VWcwrgNQ3+cXFM7WgrOrNYtd4dpRVrfdMOZuNG9QeUkVUM+dypfKGt3iujbyTFOGIpcQXgrjrp1Cvg6die97AkEA8zCWdskxOZk0XsLhxqlNqwDNnOdTOCYsSODJ/0S/tY7aasjQ9l/CaO7Ewk4KFBcKfUEFxqnS43dUESQuxGox1QJBAOLwEUAcQH1MvZ47CteEXYTUYaeWW+hpCP3Imt1FQ7Rcf1iHje+p/bkGaihkT/OQJhfvu6rm1lBZt88NpQpERYkCQB1XOGAeiAzd+h6QvrK8TH2cPDJ5CmZU3LTyQgzFW6fpE1sc3XFMPmVwoVacGcUwvng8Nxkv9hyxkff7eJUEBv0CQQCzTxZw14iXKAW5vxNYE6BGSjoEk7tQ+ljHzGOZmotl3WQ+6BKdMgQIGvH+XJzrYOEdTCCL1/YzIs2533fm67md",

tommycli 2014/08/19 16:36:03 Do we need this 'key' field? The other manifest.js

Oren Blasberg 2014/08/20 22:59:37 Done.

"name": "chrome.mediaGalleries.gallery_watch",

"version": "0.1",

- "description": "test for chrome.mediaGalleriesPrivate.addGalleryWatch, chrome.mediaGalleriesPrivate.removeGalleryWatch and onGalleryChanged events ",

+ "description": "test for chrome.mediaGalleries.addGalleryWatch, chrome.mediaGalleries.removeGalleryWatch and onGalleryChanged events ",

tommycli 2014/08/19 16:36:03 do we also test the getAllGalleryWatch and removeA

Oren Blasberg 2014/08/20 22:59:37 Yes. Done.

"app": {

"background": {

"scripts": ["test.js"]

}

- "permissions": [{"mediaGalleries": ["read", "allAutoDetected"]}, "mediaGalleriesPrivate"]

+ "permissions": [{"mediaGalleries": ["read", "allAutoDetected"]}]

}