chrome/test/data/extensions/api_test/media_galleries/gallerywatch/manifest.json - Issue 440813002: Expose gallery watching functionality to the public mediaGalleries API.

Side by Side Diff: chrome/test/data/extensions/api_test/media_galleries/gallerywatch/manifest.json

Issue 440813002: Expose gallery watching functionality to the public mediaGalleries API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup the code and prepare for review. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc ('K') | « chrome/common/extensions/api/media_galleries.idl ('k') | chrome/test/data/extensions/api_test/media_galleries/gallerywatch/test.js » ('j') | chrome/test/data/extensions/api_test/media_galleries/gallerywatch/test.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "key": "MIICeAIBADANBgkqhkiG9w0BAQEFAASCAmIwggJeAgEAAoGBAO3OlBjA3w16pm0kjJJDYI ua1wEIYLjEi+VhfHw28OW+49ekz3qms9PmFfZvJCAOJEC1lPNj4ZROG3qBE4JEJ6IgeP5tF4fSdie6kL 6VOH6tiDHe/ozI5gwcOMXIa9x8nyVyHwozBKMHQTT4ZNFhjbhkxyGYixhkOnk1GOHPiMxXAgMBAAECgY EA6Hrs0yoypRXDf62ccxzFVJWCHXNYQyl6bjuYnEKFzMSKL3Xik9BGuyATVoCeu2u3yz75J9v8WqTlPi TTsqT4bCeC4r1RGDmnS4gftWVKqHpl/HhVKRFvtu5wlPL9jdECnZdB7Viro0k8LqOqOUG2rPbKeK1Jol KQEKp+Zc7u6SkCQQD6VWcwrgNQ3+cXFM7WgrOrNYtd4dpRVrfdMOZuNG9QeUkVUM+dypfKGt3iujbyTF OGIpcQXgrjrp1Cvg6die97AkEA8zCWdskxOZk0XsLhxqlNqwDNnOdTOCYsSODJ/0S/tY7aasjQ9l/CaO 7Ewk4KFBcKfUEFxqnS43dUESQuxGox1QJBAOLwEUAcQH1MvZ47CteEXYTUYaeWW+hpCP3Imt1FQ7Rcf1 iHje+p/bkGaihkT/OQJhfvu6rm1lBZt88NpQpERYkCQB1XOGAeiAzd+h6QvrK8TH2cPDJ5CmZU3LTyQg zFW6fpE1sc3XFMPmVwoVacGcUwvng8Nxkv9hyxkff7eJUEBv0CQQCzTxZw14iXKAW5vxNYE6BGSjoEk7 tQ+ljHzGOZmotl3WQ+6BKdMgQIGvH+XJzrYOEdTCCL1/YzIs2533fm67md",	2 "key": "MIICeAIBADANBgkqhkiG9w0BAQEFAASCAmIwggJeAgEAAoGBAO3OlBjA3w16pm0kjJJDYI ua1wEIYLjEi+VhfHw28OW+49ekz3qms9PmFfZvJCAOJEC1lPNj4ZROG3qBE4JEJ6IgeP5tF4fSdie6kL 6VOH6tiDHe/ozI5gwcOMXIa9x8nyVyHwozBKMHQTT4ZNFhjbhkxyGYixhkOnk1GOHPiMxXAgMBAAECgY EA6Hrs0yoypRXDf62ccxzFVJWCHXNYQyl6bjuYnEKFzMSKL3Xik9BGuyATVoCeu2u3yz75J9v8WqTlPi TTsqT4bCeC4r1RGDmnS4gftWVKqHpl/HhVKRFvtu5wlPL9jdECnZdB7Viro0k8LqOqOUG2rPbKeK1Jol KQEKp+Zc7u6SkCQQD6VWcwrgNQ3+cXFM7WgrOrNYtd4dpRVrfdMOZuNG9QeUkVUM+dypfKGt3iujbyTF OGIpcQXgrjrp1Cvg6die97AkEA8zCWdskxOZk0XsLhxqlNqwDNnOdTOCYsSODJ/0S/tY7aasjQ9l/CaO 7Ewk4KFBcKfUEFxqnS43dUESQuxGox1QJBAOLwEUAcQH1MvZ47CteEXYTUYaeWW+hpCP3Imt1FQ7Rcf1 iHje+p/bkGaihkT/OQJhfvu6rm1lBZt88NpQpERYkCQB1XOGAeiAzd+h6QvrK8TH2cPDJ5CmZU3LTyQg zFW6fpE1sc3XFMPmVwoVacGcUwvng8Nxkv9hyxkff7eJUEBv0CQQCzTxZw14iXKAW5vxNYE6BGSjoEk7 tQ+ljHzGOZmotl3WQ+6BKdMgQIGvH+XJzrYOEdTCCL1/YzIs2533fm67md",
	tommycli 2014/08/19 16:36:03 Do we need this 'key' field? The other manifest.js Do we need this 'key' field? The other manifest.jsons in chrome/test/data/extensions/api_test/media_galleries don't seem to have it. I've never seen this before. Oren Blasberg 2014/08/20 22:59:37 Done. Show quoted text On 2014/08/19 16:36:03, tommycli wrote: > Do we need this 'key' field? The other manifest.jsons in > chrome/test/data/extensions/api_test/media_galleries don't seem to have it. I've > never seen this before. Done. Oren Blasberg 2014/08/20 22:59:37 Done. Show quoted text On 2014/08/19 16:36:03, tommycli wrote: > Do we need this 'key' field? The other manifest.jsons in > chrome/test/data/extensions/api_test/media_galleries don't seem to have it. I've > never seen this before. Done.
3 "name": "chrome.mediaGalleries.gallery_watch",	3 "name": "chrome.mediaGalleries.gallery_watch",

4 "version": "0.1",	4 "version": "0.1",

5 "description": "test for chrome.mediaGalleriesPrivate.addGalleryWatch, chrome. mediaGalleriesPrivate.removeGalleryWatch and onGalleryChanged events ",	5 "description": "test for chrome.mediaGalleries.addGalleryWatch, chrome.mediaGa lleries.removeGalleryWatch and onGalleryChanged events ",
	tommycli 2014/08/19 16:36:03 do we also test the getAllGalleryWatch and removeA do we also test the getAllGalleryWatch and removeAllGalleryWatch functions? Oren Blasberg 2014/08/20 22:59:37 Yes. Done. Show quoted text On 2014/08/19 16:36:03, tommycli wrote: > do we also test the getAllGalleryWatch and removeAllGalleryWatch functions? Yes. Done.
6 "app": {	6 "app": {

7 "background": {	7 "background": {

8 "scripts": ["test.js"]	8 "scripts": ["test.js"]

9 }	9 }

10 },	10 },

11 "permissions": [{"mediaGalleries": ["read", "allAutoDetected"]}, "mediaGalleri esPrivate"]	11 "permissions": [{"mediaGalleries": ["read", "allAutoDetected"]}]

12 }	12 }

OLD	NEW