Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 440653002: Sync setup overlay: Don't call showCustomizePage with null args (Closed)

Created:
6 years, 4 months ago by Marc Treib
Modified:
6 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, arv+watch_chromium.org, michaelpg
Project:
chromium
Visibility:
Public.

Description

Sync setup overlay: Don't call showCustomizePage with null args BUG=395105, 399587 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/sync_setup_overlay.js View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Marc Treib
PTAL!
6 years, 4 months ago (2014-08-04 08:59:41 UTC) #1
Bernhard Bauer
lgtm
6 years, 4 months ago (2014-08-04 09:13:47 UTC) #2
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 4 months ago (2014-08-04 09:14:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/440653002/1
6 years, 4 months ago (2014-08-04 09:14:23 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-04 11:06:36 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 11:17:51 UTC) #6
Message was sent while issue was closed. 
Change committed as 287317

Powered by Google App Engine
This is Rietveld 408576698