Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4949)

Unified Diff: chrome/browser/resources/sync_setup_overlay.js

Issue 440653002: Sync setup overlay: Don't call showCustomizePage with null args (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/sync_setup_overlay.js
diff --git a/chrome/browser/resources/sync_setup_overlay.js b/chrome/browser/resources/sync_setup_overlay.js
index 22bf0108fa58ac46bfe18aa0d4f411f3c9319cc4..2e0d5d91f5226ebf6f85b6626efe289da0346b43 100644
--- a/chrome/browser/resources/sync_setup_overlay.js
+++ b/chrome/browser/resources/sync_setup_overlay.js
@@ -282,6 +282,7 @@ cr.define('options', function() {
* @private
*/
setInputElementsDisabledState_: function(disabled) {
+ var self = this;
var configureElements =
$('customize-sync-preferences').querySelectorAll('input');
for (var i = 0; i < configureElements.length; i++)
@@ -291,7 +292,7 @@ cr.define('options', function() {
$('customize-link').hidden = disabled;
$('customize-link').disabled = disabled;
$('customize-link').onclick = disabled ? null : function() {
- SyncSetupOverlay.showCustomizePage(null,
+ SyncSetupOverlay.showCustomizePage(self.syncConfigureArgs_,
DataTypeSelection.SYNC_EVERYTHING);
return false;
};
@@ -599,7 +600,7 @@ cr.define('options', function() {
if (wasCustomizePageHidden)
$('choose-datatypes-ok').focus();
- if (args && args.showPassphrase) {
+ if (args.showPassphrase) {
this.showPassphraseContainer_(args);
// Give the passphrase field focus only when the dialog wasn't already
// visible.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698