chrome/browser/plugins/plugin_info_message_filter_unittest.cc - Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_info_message_filter_unittest.cc

Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/content_settings_details.h ('K') | « chrome/browser/notifications/message_center_settings_controller.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | chrome/common/chrome_content_settings_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugins/plugin_info_message_filter_unittest.cc

diff --git a/chrome/browser/plugins/plugin_info_message_filter_unittest.cc b/chrome/browser/plugins/plugin_info_message_filter_unittest.cc

index 3b612dce19d357cd4ea98bd0f7bacf0fcca915ce..e74c5f6e05b833fba635f66eb2fda4130b9277bf 100644

--- a/chrome/browser/plugins/plugin_info_message_filter_unittest.cc

+++ b/chrome/browser/plugins/plugin_info_message_filter_unittest.cc

@@ -11,6 +11,7 @@

#include "base/run_loop.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/content_settings/host_content_settings_map.h"

+#include "chrome/common/chrome_content_settings_client.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/render_messages.h"

#include "chrome/test/base/testing_pref_service_syncable.h"

@@ -217,8 +218,9 @@ TEST_F(PluginInfoMessageFilterTest, GetPluginContentSetting) {

CONTENT_SETTING_BLOCK);

// Set plugins to click-to-play on example.com and subdomains.

+ content_settings::ChromeContentSettingsClient client;

ContentSettingsPattern pattern =

- ContentSettingsPattern::FromString("[*.]example.com");

+ ContentSettingsPattern::FromString(&client, "[*.]example.com");

map->SetContentSetting(pattern,

ContentSettingsPattern::Wildcard(),

CONTENT_SETTINGS_TYPE_PLUGINS,