Clean content_settings_pattern_parser.* from unnecessary dependencies.

chrome/browser/content_settings/content_settings_details.h

Index: chrome/browser/content_settings/content_settings_details.h
diff --git a/chrome/browser/content_settings/content_settings_details.h b/chrome/browser/content_settings/content_settings_details.h
index 523f9dedb140e74d32313430194ded8952a846b0..047f536eb982f4b0a5d63bd8ec7eb56aeec16029 100644
--- a/chrome/browser/content_settings/content_settings_details.h
+++ b/chrome/browser/content_settings/content_settings_details.h
@@ -8,6 +8,7 @@
 #include <string>
 
 #include "base/basictypes.h"
+#include "chrome/common/chrome_content_settings_client.h"
 #include "chrome/common/content_settings.h"
 #include "chrome/common/content_settings_pattern.h"
 #include "components/content_settings/core/common/content_settings_types.h"
@@ -37,8 +38,9 @@ class ContentSettingsDetails {
 
   // True if all settings should be updated for the given type.
   bool update_all() const {
-    return primary_pattern_.ToString().empty() &&
-           secondary_pattern_.ToString().empty();
+    content_settings::ChromeContentSettingsClient client;
+    return primary_pattern_.ToString(&client).empty() &&

[vabr (Chromium), 2014/08/06 15:14:00]

There should be a way to tell if the pattern is empty without converting it to a
string before. That should be possible without the client.

[vasilii, 2014/08/11 13:57:18]

Markus was against changing this.

+           secondary_pattern_.ToString(&client).empty();
   }
 
   // The type of the pattern whose settings have changed.