chrome/browser/extensions/extension_special_storage_policy_unittest.cc - Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/content_settings_details.h ('K') | « chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc ('k') | chrome/browser/media/media_stream_devices_controller.cc » ('j') | chrome/common/chrome_content_settings_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

diff --git a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

index fd70f73fb01e6c8594407d6b320b1eaa4e4697bd..01658a09959547f53d4cd6356b4895b141aa51b1 100644

--- a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

+++ b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

@@ -6,6 +6,7 @@

#include "base/values.h"

#include "chrome/browser/content_settings/cookie_settings.h"

#include "chrome/browser/extensions/extension_special_storage_policy.h"

+#include "chrome/common/chrome_content_settings_client.h"

#include "chrome/common/content_settings.h"

#include "chrome/test/base/testing_profile.h"

#include "components/content_settings/core/common/content_settings_types.h"

@@ -331,8 +332,9 @@ TEST_F(ExtensionSpecialStoragePolicyTest, HasSessionOnlyOrigins) {

EXPECT_FALSE(policy_->HasSessionOnlyOrigins());

// Or the session-onlyness can affect individual origins.

+ content_settings::ChromeContentSettingsClient client;

ContentSettingsPattern pattern =

- ContentSettingsPattern::FromString("pattern.com");

+ ContentSettingsPattern::FromString(&client, "pattern.com");

cookie_settings->SetCookieSetting(pattern,

ContentSettingsPattern::Wildcard(),