chrome/browser/extensions/api/content_settings/content_settings_unittest.cc - Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_unittest.cc

Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/content_settings_details.h ('K') | « chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc ('k') | chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc » ('j') | chrome/common/chrome_content_settings_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/content_settings/content_settings_unittest.cc

diff --git a/chrome/browser/extensions/api/content_settings/content_settings_unittest.cc b/chrome/browser/extensions/api/content_settings/content_settings_unittest.cc

index a1c02373debbf8e25a405f7fcda9fb612baa234b..f157c807e5fae898db5c9649b170164c0fb465f1 100644

--- a/chrome/browser/extensions/api/content_settings/content_settings_unittest.cc

+++ b/chrome/browser/extensions/api/content_settings/content_settings_unittest.cc

@@ -5,6 +5,7 @@

#include "testing/gtest/include/gtest/gtest.h"

#include "chrome/browser/extensions/api/content_settings/content_settings_helpers.h"

+#include "chrome/common/chrome_content_settings_client.h"

namespace extensions {

namespace helpers = content_settings_helpers;

@@ -22,10 +23,11 @@ TEST(ExtensionContentSettingsHelpersTest, ParseExtensionPattern) {

{ "https://*/*", "https://*" },

{ "file:///foo/bar/baz", "file:///foo/bar/baz" },

};

+ content_settings::ChromeContentSettingsClient client;

for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestPatterns); ++i) {

std::string error;

std::string pattern_str = helpers::ParseExtensionPattern(

- kTestPatterns[i].extension_pattern, &error).ToString();

+ kTestPatterns[i].extension_pattern, &error).ToString(&client);

EXPECT_EQ(kTestPatterns[i].content_settings_pattern, pattern_str)

<< "Unexpected error parsing " << kTestPatterns[i].extension_pattern

<< ": " << error;