Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2947)

Unified Diff: chrome/browser/content_settings/cookie_settings_unittest.cc

Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/cookie_settings_unittest.cc
diff --git a/chrome/browser/content_settings/cookie_settings_unittest.cc b/chrome/browser/content_settings/cookie_settings_unittest.cc
index 833e4780790284f7792cd05e702d65fa4b413061..afdbecedfcccfd23cfce5d2cc9f01b083cd0bc13 100644
--- a/chrome/browser/content_settings/cookie_settings_unittest.cc
+++ b/chrome/browser/content_settings/cookie_settings_unittest.cc
@@ -6,6 +6,7 @@
#include "base/message_loop/message_loop.h"
#include "base/prefs/pref_service.h"
#include "chrome/browser/content_settings/cookie_settings.h"
+#include "chrome/common/chrome_content_settings_client.h"
#include "chrome/common/content_settings_pattern.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/testing_profile.h"
@@ -18,6 +19,11 @@ using content::BrowserThread;
namespace {
+ContentSettingsPattern CreatePattern(const std::string& pattern) {
+ content_settings::ChromeContentSettingsClient client;
+ return ContentSettingsPattern::FromString(&client, pattern);
+}
+
class CookieSettingsTest : public testing::Test {
public:
CookieSettingsTest()
@@ -30,7 +36,7 @@ class CookieSettingsTest : public testing::Test {
kBlockedFirstPartySite("http://no.thirdparties.com"),
kExtensionURL("chrome-extension://deadbeef"),
kHttpsSite("https://example.com"),
- kAllHttpsSitesPattern(ContentSettingsPattern::FromString("https://*")) {
+ kAllHttpsSitesPattern(CreatePattern("https://*")) {
}
protected:

Powered by Google App Engine
This is Rietveld 408576698