Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: chrome/browser/content_settings/content_settings_rule_unittest.cc

Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_rule_unittest.cc
diff --git a/chrome/browser/content_settings/content_settings_rule_unittest.cc b/chrome/browser/content_settings/content_settings_rule_unittest.cc
index 0ec57b17128d165b729415c266cbf530f9382318..47856b47c875167d1e791c7ad3f219b4e06ce1bf 100644
--- a/chrome/browser/content_settings/content_settings_rule_unittest.cc
+++ b/chrome/browser/content_settings/content_settings_rule_unittest.cc
@@ -4,6 +4,7 @@
#include <list>
+#include "chrome/common/chrome_content_settings_client.h"
#include "chrome/common/content_settings_pattern.h"
#include "chrome/browser/content_settings/content_settings_rule.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -40,17 +41,18 @@ class ListIterator : public RuleIterator {
TEST(RuleTest, ConcatenationIterator) {
std::list<Rule> rules1;
- rules1.push_back(Rule(ContentSettingsPattern::FromString("a"),
+ content_settings::ChromeContentSettingsClient client;
+ rules1.push_back(Rule(ContentSettingsPattern::FromString(&client, "a"),
ContentSettingsPattern::Wildcard(),
new base::FundamentalValue(0)));
- rules1.push_back(Rule(ContentSettingsPattern::FromString("b"),
+ rules1.push_back(Rule(ContentSettingsPattern::FromString(&client, "b"),
ContentSettingsPattern::Wildcard(),
new base::FundamentalValue(0)));
std::list<Rule> rules2;
- rules2.push_back(Rule(ContentSettingsPattern::FromString("c"),
+ rules2.push_back(Rule(ContentSettingsPattern::FromString(&client, "c"),
ContentSettingsPattern::Wildcard(),
new base::FundamentalValue(0)));
- rules2.push_back(Rule(ContentSettingsPattern::FromString("d"),
+ rules2.push_back(Rule(ContentSettingsPattern::FromString(&client, "d"),
ContentSettingsPattern::Wildcard(),
new base::FundamentalValue(0)));
@@ -62,19 +64,23 @@ TEST(RuleTest, ConcatenationIterator) {
Rule rule;
ASSERT_TRUE(concatenation_iterator.HasNext());
rule = concatenation_iterator.Next();
- EXPECT_EQ(rule.primary_pattern, ContentSettingsPattern::FromString("a"));
+ EXPECT_EQ(rule.primary_pattern, ContentSettingsPattern::FromString(&client,
+ "a"));
ASSERT_TRUE(concatenation_iterator.HasNext());
rule = concatenation_iterator.Next();
- EXPECT_EQ(rule.primary_pattern, ContentSettingsPattern::FromString("b"));
+ EXPECT_EQ(rule.primary_pattern, ContentSettingsPattern::FromString(&client,
+ "b"));
ASSERT_TRUE(concatenation_iterator.HasNext());
rule = concatenation_iterator.Next();
- EXPECT_EQ(rule.primary_pattern, ContentSettingsPattern::FromString("c"));
+ EXPECT_EQ(rule.primary_pattern, ContentSettingsPattern::FromString(&client,
+ "c"));
ASSERT_TRUE(concatenation_iterator.HasNext());
rule = concatenation_iterator.Next();
- EXPECT_EQ(rule.primary_pattern, ContentSettingsPattern::FromString("d"));
+ EXPECT_EQ(rule.primary_pattern, ContentSettingsPattern::FromString(&client,
+ "d"));
EXPECT_FALSE(concatenation_iterator.HasNext());
}

Powered by Google App Engine
This is Rietveld 408576698