Clean content_settings_pattern_parser.* from unnecessary dependencies.

chrome/browser/content_settings/content_settings_details.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_DETAILS_H_
 #define CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_DETAILS_H_
 
 #include <string>
 
 #include "base/basictypes.h"
+#include "chrome/common/chrome_content_settings_client.h"
 #include "chrome/common/content_settings.h"
 #include "chrome/common/content_settings_pattern.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 
 // Details for the CONTENT_SETTINGS_CHANGED notification. This is sent when
 // content settings change for at least one host. If settings change for more
 // than one pattern in one user interaction, this will usually send a single
 // notification with update_all() returning true instead of one notification
 // for each pattern.
 class ContentSettingsDetails {
  public:
   // Update the setting that matches this pattern/content type/resource.
   ContentSettingsDetails(const ContentSettingsPattern& primary_pattern,
                          const ContentSettingsPattern& secondary_pattern,
                          ContentSettingsType type,
                          const std::string& resource_identifier);
 
   // The item pattern whose settings have changed.
   const ContentSettingsPattern& primary_pattern() const {
     return primary_pattern_;
   }
 
   // The top level frame pattern whose settings have changed.
   const ContentSettingsPattern& secondary_pattern() const {
     return secondary_pattern_;
   }
 
   // True if all settings should be updated for the given type.
   bool update_all() const {
-    return primary_pattern_.ToString().empty() &&
-           secondary_pattern_.ToString().empty();
+    content_settings::ChromeContentSettingsClient client;
+    return primary_pattern_.ToString(&client).empty() &&

[vabr (Chromium), 2014/08/06 15:14:00]

There should be a way to tell if the pattern is empty without converting it to a
string before. That should be possible without the client.

[vasilii, 2014/08/11 13:57:18]

Markus was against changing this.

+           secondary_pattern_.ToString(&client).empty();
   }
 
   // The type of the pattern whose settings have changed.
   ContentSettingsType type() const { return type_; }
 
   // The resource identifier for the settings type that has changed.
   const std::string& resource_identifier() const {
     return resource_identifier_;
   }
 
   // True if all types should be updated. If update_all() is false, this will
   // be false as well (although the reverse does not hold true).
   bool update_all_types() const {
     return CONTENT_SETTINGS_TYPE_DEFAULT == type_;
   }
 
  private:
   ContentSettingsPattern primary_pattern_;
   ContentSettingsPattern secondary_pattern_;
   ContentSettingsType type_;
   std::string resource_identifier_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentSettingsDetails);
 };
 
 #endif  // CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_DETAILS_H_