Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 440403002: Don't share ServiceWorkerHandle between provider hosts. (Closed)

Created:
6 years, 4 months ago by falken
Modified:
6 years, 4 months ago
Reviewers:
michaeln, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Don't share ServiceWorkerHandle between provider hosts. This prevents an ASSERT failure in ServiceWorker::from() when it's passed an existing SW from a different execution context. Since ServiceWorkers minted in different documents should have different prototypes, we shouldn't expect JavaScript equality so don't need to share ServiceWorkerHandles. BUG=400980 TEST=https://codereview.chromium.org/443883003/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_handle.h View 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_handle.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_handle_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
falken
PTAL Follow-up to https://codereview.chromium.org/412833002 Although register() is changing to resolve to a registration, we still ...
6 years, 4 months ago (2014-08-06 09:29:38 UTC) #1
nhiroki
LGTM. Thank you for working on this!
6 years, 4 months ago (2014-08-06 09:40:09 UTC) #2
falken
The CQ bit was checked by falken@chromium.org
6 years, 4 months ago (2014-08-06 15:20:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/440403002/1
6 years, 4 months ago (2014-08-06 15:21:23 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 20:54:04 UTC) #5
Message was sent while issue was closed.
Change committed as 287852

Powered by Google App Engine
This is Rietveld 408576698