Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 440303004: ARM64: Support arbitrary offset in load/store pair. (Closed)

Created:
6 years, 4 months ago by Rodolph Perfetta (ARM)
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

ARM64: Support arbitrary offset in load/store pair. TF calls can generate code exceeding the instruction range. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -40 lines) Patch
M src/arm64/assembler-arm64.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 4 chunks +13 lines, -9 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 3 chunks +10 lines, -27 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 3 chunks +184 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rodolph Perfetta (ARM)
This fixes a failure when testing TF on arm64
6 years, 4 months ago (2014-08-07 10:19:54 UTC) #1
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-07 10:36:19 UTC) #2
Rodolph Perfetta (ARM)
6 years, 4 months ago (2014-08-07 10:46:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 22969 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698