Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 440243002: Unittest for page_runner, etc. should suppress output from gtest_progress_reporter (Closed)

Created:
6 years, 4 months ago by chrishenry
Modified:
6 years, 4 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

This patch does it adding a flag suppress_gtest_report. This will fix log parsing error on bot. BUG=397746 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287709

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -26 lines) Patch
M tools/perf/benchmarks/benchmark_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_measurement_unittest_base.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner_unittest.py View 17 chunks +17 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/results/gtest_progress_reporter.py View 4 chunks +20 lines, -19 lines 0 comments Download
M tools/telemetry/telemetry/results/page_test_results.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/progress_reporter.py View 2 chunks +1 line, -4 lines 0 comments Download
M tools/telemetry/telemetry/results/results_options.py View 1 4 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
chrishenry
6 years, 4 months ago (2014-08-05 22:48:54 UTC) #1
nednguyen
lgtm
6 years, 4 months ago (2014-08-05 23:18:17 UTC) #2
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-05 23:19:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/440243002/20001
6 years, 4 months ago (2014-08-05 23:22:26 UTC) #4
chrishenry
The CQ bit was unchecked by chrishenry@google.com
6 years, 4 months ago (2014-08-06 00:19:39 UTC) #5
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 4 months ago (2014-08-06 00:20:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/440243002/40001
6 years, 4 months ago (2014-08-06 00:23:12 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 06:35:59 UTC) #8
Message was sent while issue was closed.
Change committed as 287709

Powered by Google App Engine
This is Rietveld 408576698